diff options
author | Christian Kandeler <christian.kandeler@qt.io> | 2018-02-12 14:53:42 +0100 |
---|---|---|
committer | Christian Kandeler <christian.kandeler@qt.io> | 2018-02-16 11:34:20 +0000 |
commit | bca41151f08e2b198bd6ac1da1603d6933c9166a (patch) | |
tree | 3d835697679d793ee5bc4434bf760929d50641fa /src/lib/corelib/buildgraph/requesteddependencies.h | |
parent | 21c5ea0f79ad0e89eaa29ab5b91387b8454c4e3e (diff) |
Get rid of redundancies between load() and store() methods
It's silly that we have to mention each serializable data member in
both the load and the store methods.
Instead, whenever possible, forward these methods to a template that calls
the right function in the persistence backend based on its parameter.
Change-Id: I00e2dee8cdf55405f447cee27190bc97df8673e3
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Diffstat (limited to 'src/lib/corelib/buildgraph/requesteddependencies.h')
-rw-r--r-- | src/lib/corelib/buildgraph/requesteddependencies.h | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/src/lib/corelib/buildgraph/requesteddependencies.h b/src/lib/corelib/buildgraph/requesteddependencies.h index d1df4b636..7a74efe4b 100644 --- a/src/lib/corelib/buildgraph/requesteddependencies.h +++ b/src/lib/corelib/buildgraph/requesteddependencies.h @@ -41,6 +41,7 @@ #define QBS_REQUESTEDDEPENDENCIES_H #include <language/forward_decls.h> +#include <tools/persistence.h> #include <tools/set.h> #include <QString> @@ -49,7 +50,6 @@ namespace qbs { namespace Internal { -class PersistentPool; class RequestedDependencies { @@ -62,8 +62,13 @@ public: bool isUpToDate(const TopLevelProject *project) const; void load(PersistentPool &pool); - void store(PersistentPool &pool) const; + void store(PersistentPool &pool); private: + template<PersistentPool::OpType opType> void serializationOp(PersistentPool &pool) + { + pool.serializationOp<opType>(m_depsPerProduct); + } + struct QStringHash { std::size_t operator()(const QString &s) const { return qHash(s); } }; std::unordered_map<QString, Set<QString>, QStringHash> m_depsPerProduct; }; |