Fix some sub-optimal use of the persistence facility.

- Commands were potentially saved twice, and so were their strings.
- Strings in RescuableArtifactData objects were potentially saved twice.
- Remove an unneeded include of persistence.h from a header file.
- Make all PersistentObject::{load,store} methods private to make
  it clear that they may only be called via PersistentPool.

Change-Id: I17c94201dc8bc57b89132d00f3db2ec0ae2e7922
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>

1 files changed, 2 insertions, 2 deletions

diff --git a/src/lib/corelib/buildgraph/rescuableartifactdata.h b/src/lib/corelib/buildgraph/rescuableartifactdata.h
index 9c93b1cce..2229c497b 100644
--- a/src/lib/corelib/buildgraph/rescuableartifactdata.h
+++ b/src/lib/corelib/buildgraph/rescuableartifactdata.h
@@ -33,15 +33,15 @@
 #include "forward_decls.h"
 
 #include <tools/filetime.h>
-#include <tools/persistence.h>
 
 #include <QHash>
 #include <QList>
 
 namespace qbs {
 namespace Internal {
+class PersistentPool;
 
-class RescuableArtifactData : public PersistentObject
+class RescuableArtifactData
 {
 public:
     ~RescuableArtifactData();