PersistentPool: Prevent access to raw data stream

Instead, we employ our now-generic load/store interface for all
serialization operations. The advantages are two-fold:
1) It can no longer happen that carelessly written store()
   functions mistakenly dump unshared strings into the build graph,
   as it has happened several times in the past.
2) We get rid of enormous amounts of custom code dealing with
   container (de)serialization. All of this is now done centrally by a
   handful of templates in PersistentPool.

Change-Id: Ib1262da50989edda9726abd7d5a8ffdceaa0ec76
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>

1 files changed, 17 insertions, 0 deletions

diff --git a/src/lib/corelib/buildgraph/rescuableartifactdata.h b/src/lib/corelib/buildgraph/rescuableartifactdata.h
index 23685fa0d..741194cee 100644
--- a/src/lib/corelib/buildgraph/rescuableartifactdata.h
+++ b/src/lib/corelib/buildgraph/rescuableartifactdata.h
@@ -68,6 +68,23 @@ public:
                   const QString &c = QString(), bool byScanner = false)
             : productName(n), productProfile(p), childFilePath(c), addedByScanner(byScanner)
         {}
+
+        void load(PersistentPool &pool)
+        {
+            pool.load(productName);
+            pool.load(productProfile);
+            pool.load(childFilePath);
+            pool.load(addedByScanner);
+        }
+
+        void store(PersistentPool &pool) const
+        {
+            pool.store(productName);
+            pool.store(productProfile);
+            pool.store(childFilePath);
+            pool.store(addedByScanner);
+        }
+
         QString productName;
         QString productProfile;
         QString childFilePath;