aboutsummaryrefslogtreecommitdiffstats
path: root/src/lib/corelib/buildgraph
diff options
context:
space:
mode:
authorIvan Komissarov <ABBAPOH@gmail.com>2019-02-19 23:24:16 +0100
committerIvan Komissarov <ABBAPOH@gmail.com>2019-02-20 13:22:38 +0000
commit4146f1067905c3718b0504b510367bb4349b4622 (patch)
tree2554f9fb125bbd117f43ef794cc2f1fb903cf26f /src/lib/corelib/buildgraph
parent5a2e0c4d33c2aedb81adea922cfde824b1df92ad (diff)
Add const-references for non trivial types in range-for loops
This fixes -Wclazy-range-loop Change-Id: I5424d2626d6134ac7be2ce70b83f5a617f58dd7e Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/lib/corelib/buildgraph')
-rw-r--r--src/lib/corelib/buildgraph/projectbuilddata.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/lib/corelib/buildgraph/projectbuilddata.cpp b/src/lib/corelib/buildgraph/projectbuilddata.cpp
index ccb6c5123..dcb10b45b 100644
--- a/src/lib/corelib/buildgraph/projectbuilddata.cpp
+++ b/src/lib/corelib/buildgraph/projectbuilddata.cpp
@@ -280,7 +280,7 @@ void BuildDataResolver::resolveBuildData(const TopLevelProjectPtr &resolvedProje
const std::vector<ResolvedProductPtr> &allProducts = resolvedProject->allProducts();
evalContext->initializeObserver(Tr::tr("Setting up build graph for configuration %1")
.arg(resolvedProject->id()), int(allProducts.size()) + 1);
- for (ResolvedProductPtr rProduct : allProducts) {
+ for (const auto &rProduct : allProducts) {
if (rProduct->enabled)
resolveProductBuildData(rProduct);
evalContext->incrementProgressValue();
@@ -392,7 +392,7 @@ void BuildDataResolver::resolveProductBuildData(const ResolvedProductPtr &produc
product->buildData.reset(new ProductBuildData);
ArtifactSetByFileTag artifactsPerFileTag;
- for (ResolvedProductPtr dependency : qAsConst(product->dependencies)) {
+ for (const auto &dependency : qAsConst(product->dependencies)) {
QBS_CHECK(dependency->enabled);
resolveProductBuildData(dependency);
}