diff options
author | Richard Weickelt <richard@weickelt.de> | 2019-12-15 19:08:11 +0100 |
---|---|---|
committer | Richard Weickelt <richard@weickelt.de> | 2019-12-15 19:08:56 +0100 |
commit | 72be773e12177620a4f49e25da06d85d58642f68 (patch) | |
tree | ba6be891231fbb50727cd533770511272b21e5d9 /src/lib/corelib/buildgraph | |
parent | f7117d080ddce4b5f692e3a60ceddc9fe1761888 (diff) | |
parent | a499ac2a80967da83cd39d66d64f88c6b3d57205 (diff) |
Merge branch '1.15' into master
Change-Id: I893a0c195de293fead09db63b7fcdf48bbfab61c
Diffstat (limited to 'src/lib/corelib/buildgraph')
-rw-r--r-- | src/lib/corelib/buildgraph/rulesapplicator.cpp | 9 | ||||
-rw-r--r-- | src/lib/corelib/buildgraph/rulesapplicator.h | 4 |
2 files changed, 7 insertions, 6 deletions
diff --git a/src/lib/corelib/buildgraph/rulesapplicator.cpp b/src/lib/corelib/buildgraph/rulesapplicator.cpp index 437e3f4da..5d1144636 100644 --- a/src/lib/corelib/buildgraph/rulesapplicator.cpp +++ b/src/lib/corelib/buildgraph/rulesapplicator.cpp @@ -79,12 +79,13 @@ namespace Internal { RulesApplicator::RulesApplicator( ResolvedProductPtr product, - std::unordered_map<QString, const ResolvedProduct *> productsByName, - std::unordered_map<QString, const ResolvedProject *> projectsByName, + const std::unordered_map<QString, const ResolvedProduct *> &productsByName, + const std::unordered_map<QString, const ResolvedProject *> &projectsByName, Logger logger) : m_product(std::move(product)) - , m_productsByName(std::move(productsByName)) - , m_projectsByName(std::move(projectsByName)) + // m_productsByName and m_projectsByName are references, cannot move-construct + , m_productsByName(productsByName) + , m_projectsByName(projectsByName) , m_mocScanner(nullptr) , m_logger(std::move(logger)) { diff --git a/src/lib/corelib/buildgraph/rulesapplicator.h b/src/lib/corelib/buildgraph/rulesapplicator.h index 1160f3d09..da7815014 100644 --- a/src/lib/corelib/buildgraph/rulesapplicator.h +++ b/src/lib/corelib/buildgraph/rulesapplicator.h @@ -63,8 +63,8 @@ class RulesApplicator { public: RulesApplicator(ResolvedProductPtr product, - std::unordered_map<QString, const ResolvedProduct *> productsByName, - std::unordered_map<QString, const ResolvedProject *> projectsByName, + const std::unordered_map<QString, const ResolvedProduct *> &productsByName, + const std::unordered_map<QString, const ResolvedProject *> &projectsByName, Logger logger); ~RulesApplicator(); |