diff options
| author | Ivan Komissarov <ABBAPOH@gmail.com> | 2019-11-24 16:14:53 +0900 |
|---|---|---|
| committer | Ivan Komissarov <ABBAPOH@gmail.com> | 2020-01-07 12:58:12 +0000 |
| commit | 861c81ab8603a01c23e97543837670503538119e (patch) | |
| tree | 2329f5c0e80db5db3bbe4b155853168643589078 /src/lib/corelib/generators/xmlpropertygroup.h | |
| parent | 375ba8b23f0bf2b8639e9d7196f4451149798464 (diff) | |
Fix 'performance-unnecessary-value-param' warnings
Use more pass-by-const-ref since there is no point in passing objects by
value in these cases
Also, treat this warning as error
Change-Id: I5382dcd56639f535cf240205cc5c3ac667c4ece3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/lib/corelib/generators/xmlpropertygroup.h')
| -rw-r--r-- | src/lib/corelib/generators/xmlpropertygroup.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/lib/corelib/generators/xmlpropertygroup.h b/src/lib/corelib/generators/xmlpropertygroup.h index e63b515fc..e7e051a87 100644 --- a/src/lib/corelib/generators/xmlpropertygroup.h +++ b/src/lib/corelib/generators/xmlpropertygroup.h @@ -52,7 +52,7 @@ public: explicit PropertyGroup(QByteArray name); void appendProperty(QByteArray name, QVariant value); - void appendMultiLineProperty(QByteArray key, QStringList values, + void appendMultiLineProperty(QByteArray key, const QStringList &values, QChar sep = QLatin1Char(',')); void accept(INodeVisitor *visitor) const final; |