diff options
author | Christian Kandeler <christian.kandeler@theqtcompany.com> | 2015-07-30 10:14:16 +0200 |
---|---|---|
committer | Christian Kandeler <christian.kandeler@theqtcompany.com> | 2015-07-30 08:47:03 +0000 |
commit | 3811fd0855ea37eea6a02d6d3285b2503c6701d0 (patch) | |
tree | 1fbf4cdc1874c50f27ff762babd6362a4826ca20 /src/lib/corelib/language/evaluator.h | |
parent | 4b20594bd141fbfb46891ee100696a39ffe5d4c6 (diff) |
Code clean-up in corelib/language/.
- Remove unneeded #includes (particularly from header files).
- Make inline member function implementations less verbose.
- De-QObjectify the Loader class and remove unneeded members & heap
allocations.
- Minor stuff (const issues, unneeded namespace qualifications).
Change-Id: I55f2d7ed98b32faed7582bc6adfa04eb799de874
Reviewed-by: Jake Petroules <jake.petroules@petroules.com>
Diffstat (limited to 'src/lib/corelib/language/evaluator.h')
-rw-r--r-- | src/lib/corelib/language/evaluator.h | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/src/lib/corelib/language/evaluator.h b/src/lib/corelib/language/evaluator.h index 9781f5956..6806ce65c 100644 --- a/src/lib/corelib/language/evaluator.h +++ b/src/lib/corelib/language/evaluator.h @@ -33,16 +33,16 @@ #include "forward_decls.h" #include "itemobserver.h" -#include <language/scriptengine.h> #include <QHash> #include <QScriptValue> namespace qbs { namespace Internal { -class FileTags; - class EvaluatorScriptClass; +class FileTags; +class Logger; +class ScriptEngine; class Evaluator : private ItemObserver { @@ -52,7 +52,7 @@ public: Evaluator(ScriptEngine *scriptEngine, const Logger &logger); virtual ~Evaluator(); - ScriptEngine *engine() const; + ScriptEngine *engine() const { return m_scriptEngine; } QScriptValue property(const Item *item, const QString &name); QScriptValue value(const Item *item, const QString &name, bool *propertySet = 0); @@ -82,11 +82,6 @@ private: mutable QHash<FileContextConstPtr, QScriptValue> m_fileScopeMap; }; -inline ScriptEngine *Evaluator::engine() const -{ - return m_scriptEngine; -} - } // namespace Internal } // namespace qbs |