diff options
| author | Ivan Komissarov <abbapoh@gmail.com> | 2021-06-19 21:11:43 +0200 |
|---|---|---|
| committer | Ivan Komissarov <ABBAPOH@gmail.com> | 2021-07-27 13:22:51 +0000 |
| commit | e1f27a9773853c60c9dcefe44d5a6f056e32633b (patch) | |
| tree | 636fc045eac14193c3955c51c7cfa56b32529a88 /src/lib/corelib/language/moduleproviderloader.h | |
| parent | 242d81fc0f9236a8dc8a51367076d9e5d09c020e (diff) | |
Do not modify the global state after running provider
Instead, cache the result of the provider in a QHash using the provider/
module name and config as the key. This allows to have a clean state for
each Depends item, so the order in which they appear does not influence
which modules are generated. This is required for the later patch that
implements "named" providers.
Change-Id: Ia395cc94430763ed33d7ff5f2ee39e36d64f195e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/lib/corelib/language/moduleproviderloader.h')
| -rw-r--r-- | src/lib/corelib/language/moduleproviderloader.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/lib/corelib/language/moduleproviderloader.h b/src/lib/corelib/language/moduleproviderloader.h index 694cf4b5c..c720d4202 100644 --- a/src/lib/corelib/language/moduleproviderloader.h +++ b/src/lib/corelib/language/moduleproviderloader.h @@ -82,7 +82,6 @@ public: m_parameters = std::move(parameters); } - void setupKnownModuleProviders(ProductContext &product); ModuleProviderResult executeModuleProvider( ProductContext &productContext, const CodeLocation &dependsItemLocation, |