diff options
author | Richard Weickelt <richard@weickelt.de> | 2019-12-18 20:31:10 +0100 |
---|---|---|
committer | Richard Weickelt <richard@weickelt.de> | 2019-12-19 13:52:37 +0000 |
commit | 0a6651ac364513249c17f1373cfda37a7a8a74fe (patch) | |
tree | f77f0ed48db40357eacf839d18678b95287bddc7 /src/lib/corelib/language/projectresolver.cpp | |
parent | 53040c40f143210c171bc4c39affe3a5df935f78 (diff) |
Avoid an unnecessary copy operation
Clang-tidy warns about an unnecessary copy being made because the container is
std::vector<SomePtr>, but the loop variable is SomeConstPtr&.
Change-Id: I4cc640334fca4a2e58ee8ed8cebc2a3bca13f15b
Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/lib/corelib/language/projectresolver.cpp')
-rw-r--r-- | src/lib/corelib/language/projectresolver.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/lib/corelib/language/projectresolver.cpp b/src/lib/corelib/language/projectresolver.cpp index d5b84af16..fd6063381 100644 --- a/src/lib/corelib/language/projectresolver.cpp +++ b/src/lib/corelib/language/projectresolver.cpp @@ -1459,7 +1459,7 @@ void ProjectResolver::matchArtifactProperties(const ResolvedProductPtr &product, const std::vector<SourceArtifactPtr> &artifacts) { for (const SourceArtifactPtr &artifact : artifacts) { - for (const ArtifactPropertiesConstPtr &artifactProperties : product->artifactProperties) { + for (const auto &artifactProperties : product->artifactProperties) { if (!artifact->isTargetOfModule() && artifact->fileTags.intersects(artifactProperties->fileTagsFilter())) { artifact->properties = artifactProperties->propertyMap(); |