diff options
| author | Denis Shienkov <denis.shienkov@gmail.com> | 2019-02-26 14:38:54 +0300 |
|---|---|---|
| committer | Denis Shienkov <denis.shienkov@gmail.com> | 2019-02-26 15:52:26 +0000 |
| commit | 4fd17d627106fde01284075038e15cc0680611bc (patch) | |
| tree | 25c5b7e8ec774d362ad97e86d0ecd1d8527fbac5 /src/lib/corelib/tools/id.cpp | |
| parent | 0b8f0b771080e51a59664782ced6b3a1cc5111ca (diff) | |
Return initializer list where it is possible
This fixes this clang-tidy warning:
warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
Change-Id: I421e1e47462fe0e97788672684d47943af7df850
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/lib/corelib/tools/id.cpp')
| -rw-r--r-- | src/lib/corelib/tools/id.cpp | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/lib/corelib/tools/id.cpp b/src/lib/corelib/tools/id.cpp index 1c61792e6..9d31d3776 100644 --- a/src/lib/corelib/tools/id.cpp +++ b/src/lib/corelib/tools/id.cpp @@ -214,7 +214,7 @@ QString Id::toString() const QVariant Id::toSetting() const { - return QVariant(QString::fromUtf8(getStringFromId(m_id))); + return QString::fromUtf8(getStringFromId(m_id)); } /*! @@ -227,8 +227,8 @@ Id Id::fromSetting(const QVariant &variant) { const QByteArray ba = variant.toString().toUtf8(); if (ba.isEmpty()) - return Id(); - return Id(theId(ba)); + return {}; + return {theId(ba)}; } /*! @@ -242,7 +242,7 @@ Id Id::fromSetting(const QVariant &variant) Id Id::withSuffix(int suffix) const { const QByteArray ba = name() + QByteArray::number(suffix); - return Id(ba.constData()); + return {ba.constData()}; } /*! @@ -252,7 +252,7 @@ Id Id::withSuffix(int suffix) const Id Id::withSuffix(const char *suffix) const { const QByteArray ba = name() + suffix; - return Id(ba.constData()); + return {ba.constData()}; } /*! @@ -266,7 +266,7 @@ Id Id::withSuffix(const char *suffix) const Id Id::withPrefix(const char *prefix) const { const QByteArray ba = prefix + name(); - return Id(ba.constData()); + return {ba.constData()}; } bool Id::operator==(const char *name) const |