aboutsummaryrefslogtreecommitdiffstats
path: root/src/lib
diff options
context:
space:
mode:
authorIvan Komissarov <ABBAPOH@gmail.com>2019-05-02 23:30:17 +0200
committerIvan Komissarov <ABBAPOH@gmail.com>2019-05-03 09:32:07 +0000
commit69570eee906be111cee320cc75c83b2a75dd2336 (patch)
treeddc33dbb6f55323af0795d53a2d7edffdac0e78f /src/lib
parentcf822073113ae54b14994cb80af0cb8e786856c5 (diff)
Add missing virtual destructors
Change-Id: I6a20f4475b52858f79c98b5ce3dd088aac7bc46e Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/lib')
-rw-r--r--src/lib/corelib/api/projectfileupdater.cpp2
-rw-r--r--src/lib/corelib/api/projectfileupdater.h1
-rw-r--r--src/lib/corelib/buildgraph/buildgraphvisitor.h1
-rw-r--r--src/lib/corelib/buildgraph/rulegraph.h1
-rw-r--r--src/lib/corelib/language/itemobserver.h1
-rw-r--r--src/lib/corelib/language/scriptengine.h1
6 files changed, 7 insertions, 0 deletions
diff --git a/src/lib/corelib/api/projectfileupdater.cpp b/src/lib/corelib/api/projectfileupdater.cpp
index 944de7161..04f8e630f 100644
--- a/src/lib/corelib/api/projectfileupdater.cpp
+++ b/src/lib/corelib/api/projectfileupdater.cpp
@@ -119,6 +119,8 @@ ProjectFileUpdater::ProjectFileUpdater(const QString &projectFile) : m_projectFi
{
}
+ProjectFileUpdater::~ProjectFileUpdater() = default;
+
ProjectFileUpdater::LineEndingType ProjectFileUpdater::guessLineEndingType(const QByteArray &text)
{
char before = 0;
diff --git a/src/lib/corelib/api/projectfileupdater.h b/src/lib/corelib/api/projectfileupdater.h
index bc8de30eb..c0d46c747 100644
--- a/src/lib/corelib/api/projectfileupdater.h
+++ b/src/lib/corelib/api/projectfileupdater.h
@@ -54,6 +54,7 @@ namespace Internal {
class ProjectFileUpdater
{
public:
+ virtual ~ProjectFileUpdater();
void apply();
CodeLocation itemPosition() const { return m_itemPosition; }
diff --git a/src/lib/corelib/buildgraph/buildgraphvisitor.h b/src/lib/corelib/buildgraph/buildgraphvisitor.h
index 216e16a8c..cc2dde792 100644
--- a/src/lib/corelib/buildgraph/buildgraphvisitor.h
+++ b/src/lib/corelib/buildgraph/buildgraphvisitor.h
@@ -55,6 +55,7 @@ class RuleNode;
class BuildGraphVisitor
{
public:
+ virtual ~BuildGraphVisitor() = default;
virtual bool visit(Artifact *) { return true; }
virtual void endVisit(Artifact *) { }
virtual bool visit(RuleNode *) { return true; }
diff --git a/src/lib/corelib/buildgraph/rulegraph.h b/src/lib/corelib/buildgraph/rulegraph.h
index fe2fc4c3b..4ce5ecea8 100644
--- a/src/lib/corelib/buildgraph/rulegraph.h
+++ b/src/lib/corelib/buildgraph/rulegraph.h
@@ -56,6 +56,7 @@ namespace Internal {
class RuleGraphVisitor
{
public:
+ virtual ~RuleGraphVisitor() = default;
virtual void visit(const RuleConstPtr &parentRule, const RuleConstPtr &rule) = 0;
virtual void endVisit(const RuleConstPtr &rule) { Q_UNUSED(rule); }
};
diff --git a/src/lib/corelib/language/itemobserver.h b/src/lib/corelib/language/itemobserver.h
index 82a3aed24..fca3a2d85 100644
--- a/src/lib/corelib/language/itemobserver.h
+++ b/src/lib/corelib/language/itemobserver.h
@@ -48,6 +48,7 @@ class Item;
class ItemObserver
{
public:
+ virtual ~ItemObserver() = default;
virtual void onItemPropertyChanged(Item *item) = 0;
};
diff --git a/src/lib/corelib/language/scriptengine.h b/src/lib/corelib/language/scriptengine.h
index 9e4f494c6..24e133dff 100644
--- a/src/lib/corelib/language/scriptengine.h
+++ b/src/lib/corelib/language/scriptengine.h
@@ -93,6 +93,7 @@ using DubiousContextList = std::vector<DubiousContext>;
class ResourceAcquiringScriptObject
{
public:
+ virtual ~ResourceAcquiringScriptObject() = default;
virtual void releaseResources() = 0;
};