aboutsummaryrefslogtreecommitdiffstats
path: root/src/lib
diff options
context:
space:
mode:
authorChristian Kandeler <christian.kandeler@qt.io>2018-06-06 14:01:26 +0200
committerChristian Kandeler <christian.kandeler@qt.io>2018-06-08 13:00:35 +0000
commitbd9f5be3341f0b1c4f0f96a9f6f129dfebac6d43 (patch)
tree100f2ae12de2407b7b96cc3f4f771cac2a450f94 /src/lib
parent5f71b2220f9ff6838799c407972309bff1e8fc96 (diff)
Prevent adding empty file paths as dependencies
The input artifact scanner was missing a check, so empty paths could end up in the list of file dependencies. As a result, the respective artifact would get rebuilt every time. Change-Id: I34e48776856224dc885f03d34d40cae88d7d5e4b Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Diffstat (limited to 'src/lib')
-rw-r--r--src/lib/corelib/buildgraph/inputartifactscanner.cpp2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/lib/corelib/buildgraph/inputartifactscanner.cpp b/src/lib/corelib/buildgraph/inputartifactscanner.cpp
index 644b95d79..d183b1879 100644
--- a/src/lib/corelib/buildgraph/inputartifactscanner.cpp
+++ b/src/lib/corelib/buildgraph/inputartifactscanner.cpp
@@ -255,6 +255,8 @@ void InputArtifactScanner::resolveScanResultDependencies(const Artifact *inputAr
if (FileInfo::isAbsolute(dependencyFilePath)) {
resolveDepencency(dependency, inputArtifact->product.get(), &resolvedDependency);
+ if (resolvedDependency.filePath.isEmpty())
+ goto unresolved;
goto resolved;
}