Fix 'performance-unnecessary-value-param' warnings

Use more pass-by-const-ref since there is no point in passing objects by
value in these cases

Also, treat this warning as error

Change-Id: I5382dcd56639f535cf240205cc5c3ac667c4ece3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>

2 files changed, 4 insertions, 4 deletions

diff --git a/src/plugins/generator/iarew/archs/arm/armgeneralsettingsgroup_v8.cpp b/src/plugins/generator/iarew/archs/arm/armgeneralsettingsgroup_v8.cpp
index 911873cf4..0bbfbaafb 100644
--- a/src/plugins/generator/iarew/archs/arm/armgeneralsettingsgroup_v8.cpp
+++ b/src/plugins/generator/iarew/archs/arm/armgeneralsettingsgroup_v8.cpp
@@ -499,7 +499,7 @@ void ArmGeneralSettingsGroup::buildLibraryOptionsTwoPage(
 }
 
 void ArmGeneralSettingsGroup::buildLibraryConfigPage(
-        const QString baseDirectory,
+        const QString &baseDirectory,
         const ProductData &qbsProduct)
 {
     const LibraryConfigPageOptions opts(baseDirectory, qbsProduct);
@@ -523,7 +523,7 @@ void ArmGeneralSettingsGroup::buildLibraryConfigPage(
 }
 
 void ArmGeneralSettingsGroup::buildOutputPage(
-        const QString baseDirectory,
+        const QString &baseDirectory,
         const ProductData &qbsProduct)
 {
     const OutputPageOptions opts(baseDirectory, qbsProduct);
diff --git a/src/plugins/generator/iarew/archs/arm/armgeneralsettingsgroup_v8.h b/src/plugins/generator/iarew/archs/arm/armgeneralsettingsgroup_v8.h
index 420e98008..0b1564b3c 100644
--- a/src/plugins/generator/iarew/archs/arm/armgeneralsettingsgroup_v8.h
+++ b/src/plugins/generator/iarew/archs/arm/armgeneralsettingsgroup_v8.h
@@ -49,9 +49,9 @@ private:
     void buildTargetPage(const ProductData &qbsProduct);
     void buildLibraryOptionsOnePage(const ProductData &qbsProduct);
     void buildLibraryOptionsTwoPage(const ProductData &qbsProduct);
-    void buildLibraryConfigPage(const QString baseDirectory,
+    void buildLibraryConfigPage(const QString &baseDirectory,
                                 const ProductData &qbsProduct);
-    void buildOutputPage(const QString baseDirectory,
+    void buildOutputPage(const QString &baseDirectory,
                          const ProductData &qbsProduct);
 };