Fix 'performance-unnecessary-value-param' in Logger

Most Logger's shift operators call .write() which "mutates" passed
object except three operators which simply use QString overload. This
produces clang-tidy warning about unnecessary copy. Use direct call to
.write() to suppress the warning and have consistent function signatures

Change-Id: I1c42e16948147315e40edf263e887ebeee4a4388
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>

1 files changed, 6 insertions, 3 deletions

diff --git a/src/lib/corelib/logging/logger.cpp b/src/lib/corelib/logging/logger.cpp
index b962afa92..2ed29c4c2 100644
--- a/src/lib/corelib/logging/logger.cpp
+++ b/src/lib/corelib/logging/logger.cpp
@@ -183,17 +183,20 @@ LogWriter operator<<(LogWriter w, const QVariant &variant)
 
 LogWriter operator<<(LogWriter w, int n)
 {
-    return w << QString::number(n);
+    w.write(QString::number(n));
+    return w;
 }
 
 LogWriter operator<<(LogWriter w, qint64 n)
 {
-    return w << QString::number(n);
+    w.write(QString::number(n));
+    return w;
 }
 
 LogWriter operator<<(LogWriter w, bool b)
 {
-    return w << QString::fromLatin1(b ? "true" : "false");
+    w.write(QString::fromLatin1(b ? "true" : "false"));
+    return w;
 }
 
 LogWriter operator<<(LogWriter w, const MessageTag &tag)