diff options
| author | Ivan Komissarov <ABBAPOH@gmail.com> | 2019-11-24 14:36:41 +0900 |
|---|---|---|
| committer | Ivan Komissarov <ABBAPOH@gmail.com> | 2019-12-18 10:31:36 +0000 |
| commit | e9eea57e5b0e048494cc57017eb2972f79cfd4a2 (patch) | |
| tree | 1f9847b40a6169a6067d57d891116da170a08f15 /src | |
| parent | 4f359d1284c5c6425979a0426806f52a0ee783ff (diff) | |
Use pass-by-value in Profile
Change-Id: I617e09de3e2a18da0178386cc81d64e4412ec877
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src')
| -rw-r--r-- | src/lib/corelib/tools/profile.cpp | 10 | ||||
| -rw-r--r-- | src/lib/corelib/tools/profile.h | 2 |
2 files changed, 6 insertions, 6 deletions
diff --git a/src/lib/corelib/tools/profile.cpp b/src/lib/corelib/tools/profile.cpp index 7e594fd2d..2eac25091 100644 --- a/src/lib/corelib/tools/profile.cpp +++ b/src/lib/corelib/tools/profile.cpp @@ -63,13 +63,13 @@ namespace qbs { /*! * \brief Creates an object giving access to the settings for profile \c name. */ -Profile::Profile(const QString &name, Settings *settings, const QVariantMap &profiles) - : m_name(name), +Profile::Profile(QString name, Settings *settings, QVariantMap profiles) + : m_name(std::move(name)), m_settings(settings), - m_values(profiles.value(name).toMap()), - m_profiles(profiles) + m_values(profiles.value(m_name).toMap()), + m_profiles(std::move(profiles)) { - QBS_ASSERT(name == cleanName(name), return); + QBS_ASSERT(m_name == cleanName(m_name), return); } bool Profile::exists() const diff --git a/src/lib/corelib/tools/profile.h b/src/lib/corelib/tools/profile.h index aa8b7ef10..0eee23ae4 100644 --- a/src/lib/corelib/tools/profile.h +++ b/src/lib/corelib/tools/profile.h @@ -55,7 +55,7 @@ class Settings; class QBS_EXPORT Profile { public: - Profile(const QString &name, Settings *settings, const QVariantMap &profiles = QVariantMap()); + Profile(QString name, Settings *settings, QVariantMap profiles = QVariantMap()); bool exists() const; QVariant value(const QString &key, const QVariant &defaultValue = QVariant(), |