Consolidate "safe identifier" code by introducing qbs.rfc1034identifier.

Instead of duplicating this logic in three places across two languages,
it's now implemented in a central location in C++ and exposed to
JavaScript. As an intentional side effect, build directory naming now
uses - instead of _ as per the RFC 1034 name charset.

Change-Id: I1a7c3ec45efc5b29f9a05067e4c2cf640af4a7aa
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

1 files changed, 1 insertions, 8 deletions

diff --git a/tests/auto/shared.h b/tests/auto/shared.h
index ea45f727e..67ea19128 100644
--- a/tests/auto/shared.h
+++ b/tests/auto/shared.h
@@ -64,14 +64,7 @@ inline QString relativeProductBuildDir(const QString &productName,
                                        const QString &profileName = QString())
 {
     const QString fullName = uniqueProductName(productName, profileName);
-    QString dirName = fullName;
-    for (int i = 0; i < dirName.count(); ++i) {
-        QCharRef c = dirName[i];
-        const bool okChar = (c >= '0' && c <= '9') || (c >= 'A' && c <= 'Z')
-                || (c >= 'a' && c <= 'z') || c == '_' || c == '.';
-        if (!okChar)
-            c = QChar::fromLatin1('_');
-    }
+    QString dirName = qbs::Internal::HostOsInfo::rfc1034Identifier(fullName);
     const QByteArray hash = QCryptographicHash::hash(fullName.toUtf8(), QCryptographicHash::Sha1);
     dirName.append('.').append(hash.toHex().left(8));
     return relativeBuildDir() + '/' + dirName;