aboutsummaryrefslogtreecommitdiffstats
path: root/tests/benchmarker
diff options
context:
space:
mode:
authorIvan Komissarov <ABBAPOH@gmail.com>2019-12-23 12:30:36 +0100
committerIvan Komissarov <ABBAPOH@gmail.com>2020-01-06 14:12:46 +0000
commitcc58b80adb5d2b5725f3e5a6e67a02236aafa3ca (patch)
tree622f09ff48cb01593677709adb326a1053b28426 /tests/benchmarker
parent0f188517ef590a935c367b5906b88349d64a3a27 (diff)
qbs_benchmarker: Validate commit parameters
It's possible to copy&paste old commit instead of a new one and easy to overlook that mistake. Change-Id: I408f256ba6b2f419b7cf90b7ed9ee582f91b081b Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'tests/benchmarker')
-rw-r--r--tests/benchmarker/commandlineparser.cpp4
1 files changed, 4 insertions, 0 deletions
diff --git a/tests/benchmarker/commandlineparser.cpp b/tests/benchmarker/commandlineparser.cpp
index e725ad0a0..9b08bd60d 100644
--- a/tests/benchmarker/commandlineparser.cpp
+++ b/tests/benchmarker/commandlineparser.cpp
@@ -82,6 +82,10 @@ void CommandLineParser::parse()
}
m_oldCommit = parser.value(oldCommitOption);
m_newCommit = parser.value(newCommitOption);
+ if (m_oldCommit == m_newCommit) {
+ throw Exception(QStringLiteral("Error parsing command line: "
+ "'new commit' and 'old commit' must be different commits.\n%1").arg(parser.helpText()));
+ }
m_testProjectFilePath = parser.value(testProjectOption);
m_qbsRepoDirPath = parser.value(qbsRepoOption);
const QStringList activitiesList = parser.value(activitiesOption).split(',');