diff options
| author | Ivan Komissarov <ABBAPOH@gmail.com> | 2019-11-24 16:14:53 +0900 |
|---|---|---|
| committer | Ivan Komissarov <ABBAPOH@gmail.com> | 2020-01-07 12:58:12 +0000 |
| commit | 861c81ab8603a01c23e97543837670503538119e (patch) | |
| tree | 2329f5c0e80db5db3bbe4b155853168643589078 /tests | |
| parent | 375ba8b23f0bf2b8639e9d7196f4451149798464 (diff) | |
Fix 'performance-unnecessary-value-param' warnings
Use more pass-by-const-ref since there is no point in passing objects by
value in these cases
Also, treat this warning as error
Change-Id: I5382dcd56639f535cf240205cc5c3ac667c4ece3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/auto/api/tst_api.cpp | 4 | ||||
| -rw-r--r-- | tests/auto/api/tst_api.h | 2 | ||||
| -rw-r--r-- | tests/auto/blackbox/tst_blackbox.cpp | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/tests/auto/api/tst_api.cpp b/tests/auto/api/tst_api.cpp index 24c966c55..003b63ff6 100644 --- a/tests/auto/api/tst_api.cpp +++ b/tests/auto/api/tst_api.cpp @@ -1054,7 +1054,7 @@ void TestApi::excludedInputs() QCOMPARE(dummyCount, 3); } -static qbs::ErrorInfo forceRuleEvaluation(const qbs::Project project) +static qbs::ErrorInfo forceRuleEvaluation(const qbs::Project &project) { qbs::BuildOptions buildOptions; buildOptions.setDryRun(true); @@ -2963,7 +2963,7 @@ void TestApi::uic() qbs::ErrorInfo TestApi::doBuildProject( const QString &projectFilePath, BuildDescriptionReceiver *buildDescriptionReceiver, ProcessResultReceiver *procResultReceiver, TaskReceiver *taskReceiver, - const qbs::BuildOptions &options, const QVariantMap overriddenValues) + const qbs::BuildOptions &options, const QVariantMap &overriddenValues) { qbs::SetupProjectParameters params = defaultSetupParameters(projectFilePath); params.setOverriddenValues(overriddenValues); diff --git a/tests/auto/api/tst_api.h b/tests/auto/api/tst_api.h index aa00ddc99..39eada57a 100644 --- a/tests/auto/api/tst_api.h +++ b/tests/auto/api/tst_api.h @@ -161,7 +161,7 @@ private: ProcessResultReceiver *procResultReceiver = 0, TaskReceiver *taskReceiver = 0, const qbs::BuildOptions &options = qbs::BuildOptions(), - const QVariantMap overriddenValues = QVariantMap()); + const QVariantMap &overriddenValues = QVariantMap()); LogSink * const m_logSink; const QString m_sourceDataDir; diff --git a/tests/auto/blackbox/tst_blackbox.cpp b/tests/auto/blackbox/tst_blackbox.cpp index 8a38de474..6f798f467 100644 --- a/tests/auto/blackbox/tst_blackbox.cpp +++ b/tests/auto/blackbox/tst_blackbox.cpp @@ -5570,7 +5570,7 @@ void TestBlackbox::qbsSession() const QJsonObject group = v.toObject(); const QJsonArray sourceArtifacts = group.value("source-artifacts").toArray(); - const auto findArtifact = [&sourceArtifacts](const QString fileName) { + const auto findArtifact = [&sourceArtifacts](const QString &fileName) { for (const QJsonValue &v : sourceArtifacts) { const QJsonObject artifact = v.toObject(); if (QFileInfo(artifact.value("file-path").toString()).fileName() |