Apply 'modernize-pass-by-value' fix-it

Also, treat this warning as error

This amends 936eee744db9b2fd1b9b66d168d80a113002aad2

Change-Id: I372c3b11baa08375d581052282f4546b2ba2e057
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>

8 files changed, 19 insertions, 18 deletions

diff --git a/tests/auto/blackbox/tst_blackboxbase.h b/tests/auto/blackbox/tst_blackboxbase.h
index 251f3752d..c1c4d39b2 100644
--- a/tests/auto/blackbox/tst_blackboxbase.h
+++ b/tests/auto/blackbox/tst_blackboxbase.h
@@ -42,14 +42,14 @@ public:
         init();
     }
 
-    QbsRunParameters(const QString &cmd, const QStringList &args = QStringList())
-        : command(cmd), arguments(args)
+    QbsRunParameters(QString cmd, QStringList args = QStringList())
+        : command(std::move(cmd)), arguments(std::move(args))
     {
         init();
     }
 
-    QbsRunParameters(const QStringList &args)
-        : arguments(args)
+    QbsRunParameters(QStringList args)
+        : arguments(std::move(args))
     {
         init();
     }
diff --git a/tests/benchmarker/benchmarker.cpp b/tests/benchmarker/benchmarker.cpp
index 5ecdbf08b..2cc442a72 100644
--- a/tests/benchmarker/benchmarker.cpp
+++ b/tests/benchmarker/benchmarker.cpp
@@ -34,16 +34,17 @@
 #include <QtConcurrent/qtconcurrentrun.h>
 
 #include <iostream>
+#include <utility>
 
 namespace qbsBenchmarker {
 
-Benchmarker::Benchmarker(Activities activities, const QString &oldCommit, const QString &newCommit,
-                         const QString &testProject, const QString &qbsRepo)
+Benchmarker::Benchmarker(Activities activities, QString oldCommit, QString newCommit,
+                         QString testProject, QString qbsRepo)
     : m_activities(activities)
-    , m_oldCommit(oldCommit)
-    , m_newCommit(newCommit)
-    , m_testProject(testProject)
-    , m_qbsRepo(qbsRepo)
+    , m_oldCommit(std::move(oldCommit))
+    , m_newCommit(std::move(newCommit))
+    , m_testProject(std::move(testProject))
+    , m_qbsRepo(std::move(qbsRepo))
 {
 }
 
diff --git a/tests/benchmarker/benchmarker.h b/tests/benchmarker/benchmarker.h
index 9b6d5a157..6313e8094 100644
--- a/tests/benchmarker/benchmarker.h
+++ b/tests/benchmarker/benchmarker.h
@@ -53,8 +53,8 @@ using BenchmarkResults = QHash<Activity, BenchmarkResult>;
 class Benchmarker
 {
 public:
-    Benchmarker(Activities activities, const QString &oldCommit, const QString &newCommit,
-                const QString &testProject, const QString &qbsRepo);
+    Benchmarker(Activities activities, QString oldCommit, QString newCommit,
+                QString testProject, QString qbsRepo);
     ~Benchmarker();
 
     void benchmark();
diff --git a/tests/benchmarker/exception.h b/tests/benchmarker/exception.h
index 216189b70..9fab479ea 100644
--- a/tests/benchmarker/exception.h
+++ b/tests/benchmarker/exception.h
@@ -35,7 +35,7 @@ namespace qbsBenchmarker {
 
 class Exception : public QException {
 public:
-    explicit Exception(const QString &description) : m_description(description) {}
+    explicit Exception(QString description) : m_description(std::move(description)) {}
     ~Exception() throw() override = default;
 
     QString description() const { return m_description; }
diff --git a/tests/benchmarker/valgrindrunner.cpp b/tests/benchmarker/valgrindrunner.cpp
index 344a23516..174781318 100644
--- a/tests/benchmarker/valgrindrunner.cpp
+++ b/tests/benchmarker/valgrindrunner.cpp
@@ -44,10 +44,10 @@
 
 namespace qbsBenchmarker {
 
-ValgrindRunner::ValgrindRunner(Activities activities, const QString &testProject,
+ValgrindRunner::ValgrindRunner(Activities activities, QString testProject,
                                const QString &qbsBuildDir, const QString &baseOutputDir)
     : m_activities(activities)
-    , m_testProject(testProject)
+    , m_testProject(std::move(testProject))
     , m_qbsBinary(qbsBuildDir + "/bin/qbs")
     , m_baseOutputDir(baseOutputDir)
 {
diff --git a/tests/benchmarker/valgrindrunner.h b/tests/benchmarker/valgrindrunner.h
index 3ec82a6a2..378723868 100644
--- a/tests/benchmarker/valgrindrunner.h
+++ b/tests/benchmarker/valgrindrunner.h
@@ -55,7 +55,7 @@ public:
 class ValgrindRunner
 {
 public:
-    ValgrindRunner(Activities activities, const QString &testProject, const QString &qbsBuildDir,
+    ValgrindRunner(Activities activities, QString testProject, const QString &qbsBuildDir,
                     const QString &baseOutputDir);
 
     void run();
diff --git a/tests/fuzzy-test/commandlineparser.h b/tests/fuzzy-test/commandlineparser.h
index 6dcbf84bc..76b49331b 100644
--- a/tests/fuzzy-test/commandlineparser.h
+++ b/tests/fuzzy-test/commandlineparser.h
@@ -35,7 +35,7 @@
 class ParseException : public std::exception
 {
 public:
-    ParseException(const QString &error) : errorMessage(error) { }
+    ParseException(QString error) : errorMessage(std::move(error)) { }
     ~ParseException() throw() override = default;
 
     QString errorMessage;
diff --git a/tests/fuzzy-test/fuzzytester.h b/tests/fuzzy-test/fuzzytester.h
index bc1fc5f18..2d0279e1a 100644
--- a/tests/fuzzy-test/fuzzytester.h
+++ b/tests/fuzzy-test/fuzzytester.h
@@ -35,7 +35,7 @@
 
 class TestError {
 public:
-    TestError(const QString &errorMessage) : errorMessage(errorMessage) {}
+    TestError(QString errorMessage) : errorMessage(std::move(errorMessage)) {}
     ~TestError() throw() = default;
 
     QString errorMessage;