summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Print total warnings count created by clang-tidyHEADmasterRichard Weickelt2 days1-1/+3
| | | | | | | | This makes it a bit easier to compare different patches. Change-Id: I6ac2c981896f1f34e529b9718bf4ccfdab194e14 Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Disable some clang-tidy checksIvan Komissarov2 days2-2/+2
| | | | | | | | | To reduce overall noise. Some checks can be enabled later after they are fixed Change-Id: Ic9d144bb5e896569acb3ee0de1d852dd53e2c10a Reviewed-by: Richard Weickelt <richard@weickelt.de> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Remove duplicate files from compile_commands.json when running analyzerIvan Komissarov3 days1-4/+8
| | | | | | | | It doesn't make sense to run clang-tidy on the same file multiple times (even though compile flags can be different) Change-Id: Ia6b26e0ec75e798fe10286ab637e039ed7774486 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Fix setting base profile for the QBS_AUTOTEST_PROFILEIvan Komissarov5 days1-4/+7
| | | | | | Change-Id: I37587ea0a691560bc1f37fb4ee2525ef9657e7f0 Reviewed-by: Richard Weickelt <richard@weickelt.de> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Fix 'performance-move-const-arg' warningsIvan Komissarov5 days9-15/+15
| | | | | | | | | | | Also, treat that warning as error In some places move is redundant (e.g. when moving int or enum), in others it wasn't working as expected (i.e. not moving, but copying instead), in some, const-ref was (uselessly) moved. Fix those places Change-Id: I0b38667a71967fa35ca627990d3c12124fb62af0 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Ignore included .moc files when running clang-tidyIvan Komissarov5 days1-1/+1
| | | | | | | | | Header-filter regexp was a bit wrong and accepted moc files included in cpp files. This is not desired, since moc files are auto-generated and produce some warnings that cannot be fixed Change-Id: Iedc065f89129ad0f85df17988dc6e050e6edf7d6 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Make Version constexprIvan Komissarov8 days1-19/+25
| | | | | Change-Id: I0a97fc1db5986945bad5634d38a079faa267fd2c Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Inline methods in VersionIvan Komissarov9 days2-81/+35
| | | | | | | | | This is faster since those functions will be inlined This also will allow to use Version in a constexpr context Change-Id: Idc5ea68be7d0fdaf3218167c16fe68b539c10064 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Enable clang-tidy job on TravisIvan Komissarov9 days3-6/+46
| | | | | | | | | | | | | | | This runs predefined clang-tidy checks on the QBS sources, excluding examples and tests Most checks are displayed as warings, however, some checks are treated as errors to avoid adding regressions in the new code clang-analyzer-* checks are not enabled due to performance reasons (otherwise, Travis job hits 50 min) Change-Id: I686003d2526a11d90fc74c88104b4357d67620d1 Reviewed-by: Richard Weickelt <richard@weickelt.de> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Add missing move-ctors to the ErrorItem and ErrorInfoIvan Komissarov10 days4-5/+20
| | | | | Change-Id: I4db70f62db5f8f1428cbdd6ee60ac393cfc93298 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Use std::unique_ptr in SessionPacketReaderIvan Komissarov10 days2-6/+8
| | | | | | | This allows to have a defaulted destructor Change-Id: I7c5c5819460d37f162a93319d23efaf2ad98def6 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Fix 'modernize-use-emplace' warningsIvan Komissarov12 days10-15/+15
| | | | | | | | | | std::vector::emplace_back creates an object in a vector and allows to avoid creating temporary object that is than moved into a vector. This simplifies code a bit as it is not necessary to call std::make_pair or use uniform initialization to create a temporary object Change-Id: I0c5500a818f78d07bc753e25f529c06762cb615c Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Update Dockerfile for Ubuntu/bionic to install clang-8Ivan Komissarov12 days2-3/+10
| | | | | | | | Requied to be able to run clang-tidy Change-Id: Ie0b6eb3229e8a93ea2e7dd10d75824fb40702fa6 Reviewed-by: Richard Weickelt <richard@weickelt.de> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Refactor file pointer management in PersistentPoolIvan Komissarov2019-11-282-15/+5
| | | | | | | | This allows to make the dtor default Also fixes 'bugprone-unused-return-value' warning Change-Id: Ib8a335f9eed29d549ad87096f32c9df5597f9f3b Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Apply 'modernize-make-unique' fix-itIvan Komissarov2019-11-2814-20/+34
| | | | | Change-Id: I93783cfa3267f69237b0ad888d0747e4272cda0a Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Improve libraryPaths and dynamicLibraries documentationMitch Curtis2019-11-281-0/+20
| | | | | | Task-number: QBS-1516 Change-Id: I7403ed5ef1873e97da6848c7eaa0ddd21812c44c Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Doc: add a how-to for printing the value of propertiesMitch Curtis2019-11-271-0/+20
| | | | | | | | Change-Id: I3684f2e1fb92f2b10fb97222fa9e777340608b99 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Richard Weickelt <richard@weickelt.de> Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Kill the keep-alive background processRichard Weickelt2019-11-261-1/+1
| | | | | | | | | | | | | | | The sleep command in background was not killed although its parent process was. That caused builds on Travis to idle for up to 590s after completion in worst-case. This patch extends the EXIT trap and ensures that the sleep command is killed. There is unfortunately no generic way in Bash to achieve that (without writing lots of convoluted code) because utilities like pkill are not available in Git Bash. Change-Id: Ibbb5683e57c242e58133c1860ec9c921b7e449b7 Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Document how to create a reusable Group of filesMitch Curtis2019-11-261-0/+74
| | | | | | | Change-Id: I46050db2a95292a298e448fc2cfbfde04b1228d6 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Richard Weickelt <richard@weickelt.de> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Apply 'modernize-deprecated-headers' fix-itIvan Komissarov2019-11-2610-11/+11
| | | | | | | | C++ standard library provides "modern" headers for the functions from the C standard library Change-Id: I51ac83c1f072773c6a5909a2025e737be539e906 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Enable clcache on WindowsRichard Weickelt2019-11-261-2/+7
| | | | | | | | Works like ccache on Linux/macOS, but ccache-alike invocation requires an unreleased version. Change-Id: Ib206eef9d34514aa4a087cf38883241d58ee3992 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Apply 'readability-container-size-empty' fix-itIvan Komissarov2019-11-254-5/+5
| | | | | Change-Id: I4693b9a2c941b63e8b60bbe5d188031e648354f6 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Make Engine ctor defaultIvan Komissarov2019-11-252-5/+3
| | | | | Change-Id: If6ec5e4cd02e14f63bdf9b56e605b14b1206c3eb Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Apply 'modernize-return-braced-init-list' fix-itIvan Komissarov2019-11-254-9/+8
| | | | | Change-Id: Idbf3ad63c2f8cda295ea40f529a07129c2d979e7 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Replace QList<qbs::Profile> with std::vector<qbs::Profile>Ivan Komissarov2019-11-2515-20/+22
| | | | | | | | | | | | First, QList is not very good with qbs::Profile since sizeof(qbs::Profile) > sizeof(void*) Second, there's a common pattern to move value when appending to a list: profiles.push_back(std::move(profile)), but it doesn't work with QList since it doesn't have push_back(T&&) overload Change-Id: Idc288390d8a89687ba5fe8be678d4fbd803c4249 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Apply 'modernize-use-equals-default' fix-itIvan Komissarov2019-11-2583-384/+142
| | | | | Change-Id: Iabdc777d2e8492d9903109365b0f3b1a5441ca11 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Add a check for the readlink result in processNameByPid()Ivan Komissarov2019-11-251-1/+2
| | | | | | | | This fixes release build on Linux Change-Id: I67fb4b01bf578db625343b50b06c0d1a0457999c Reviewed-by: Richard Weickelt <richard@weickelt.de> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Apply 'modernize-use-override' fix-itIvan Komissarov2019-11-253-6/+6
| | | | | Change-Id: I1e31b2983568848db8af7139244fe96821ac3b1e Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Enable ccache on Linux/DockerRichard Weickelt2019-11-255-9/+23
| | | | | | | | This speeds up CI builds a lot. Change-Id: I53962e1683b4dd923c3a7d254db24164a4e623a6 Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Brings the listPropertyOrder test back into a working stateRichard Weickelt2019-11-252-2/+3
| | | | | | | | | | | The test case did not (anymore) do what it should. There was no output on stdErr because console.info() was used and also -qq was set which would have even suppressed warnings. Hence the test case always succeeded regardless of the property order. Change-Id: I8450abcdd032bb02726dc3a57353d8649b55d7df Reviewed-by: Richard Weickelt <richard@weickelt.de> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Enable ccache on macOSIvan Komissarov2019-11-221-1/+5
| | | | | | | | | | Cold Cache: 27:47 (XCode 10.2) / 31:08 (XCode 11.0) Warm Cache: 22:53 (XCode 10.2) / 24:20 (XCode 11.0) Change-Id: I68449a1b921a63d1102c58255a6badb3098b4170 Reviewed-by: Richard Weickelt <richard@weickelt.de> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Enable cpp.treatWarningsAsErrors when building Qbs on TravisIvan Komissarov2019-11-212-1/+2
| | | | | Change-Id: I45a6bbc31a5be8c20b0fe7877e1fc42833e68ddd Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Fix -Wunused-but-set-variable on Ubuntu/mingwIvan Komissarov2019-11-201-1/+1
| | | | | Change-Id: I4d837f47f9a2783060fe5832005015ea9adaf5e7 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Fix compiler warnings on macOSIvan Komissarov2019-11-205-6/+7
| | | | | | Change-Id: I865357bf74bdaf88eabae5681c70a6e5032e274d Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Merge branch '1.15' into masterRichard Weickelt2019-11-204-3/+50
|\ | | | | | | Change-Id: I1755128478ccaa23952a482ed3ea546898807f62
| * Do not pass macosx_version_min to the linkerIvan Komissarov2019-11-191-1/+1
| | | | | | | | | | | | | | | | | | Minimum OS version is controlled by -target flag now. For example, "-target x86_64-apple-macosx10.14" tells clang to set minimum macOS version to 10.14 Change-Id: Iaee002e80d6a02e3a2790757f640dc4a25af8e9b Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
| * Add changelog for 1.15.0 releaseRichard Weickelt2019-11-181-0/+44
| | | | | | | | | | | | | | Change-Id: Ic143a00f209d04cb7907fa34373b9c2e043d7760 Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io> Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com>
| * Set right dependencies for static qmake buildAlberto Mardegan2019-11-121-1/+4
| | | | | | | | | | | | | | | | | | When building statically, it's important that plugins are built before the application which is going to use them. Change-Id: I0e32650b96a2e18c82a884501e7b478f7febc528 Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com> Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
| * MingW: fix path of windres binaryAlberto Mardegan2019-11-081-1/+1
| | | | | | | | | | | | | | | | This was accidentally broken in 18a3b64ab07ade6bfc9bb068956beed2032d9b58. Change-Id: I87a106adda094500395049030f6ece652abc9dc9 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | Add Xcode 11 to CIRichard Weickelt2019-11-202-5/+9
| | | | | | | | | | | | | | | | | | This requires Qbs 1.14.1. And while we are at it, we can also upgrade Qt to 5.12.6 in all environments. Task-number: QBS-1495 Change-Id: Iddb067cca37956f93c9bdf2acc95b2282a232b2b Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | Suppress warnings for the protobuf addressbook exampleIvan Komissarov2019-11-181-0/+1
| | | | | | | | | | Change-Id: I33fb2e7d16c8f6a31426b9b3f4e0c7ecb1583600 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | Fix nullpointer access and heap-use-after-free errorJochen Ulrich2019-11-162-7/+19
| | | | | | | | | | | | Task-number: QBS-1485 Change-Id: Id43e997a73ff55c3b438edb553806b61d45a8bdf Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | Simplify multiplexing testcaseRichard Weickelt2019-11-152-45/+0
| | | | | | | | | | | | | | | | | | | | Remove distracting items not relevant for the testcase itself. This was maybe a blackboxtest at some point in history, but now it is only an API test. We might need to expand it in the future and thus it is important to keep it free from irrelevant code. Change-Id: Icc0d962c4dbd21c32b4a99987eade2f66b8b78ac Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | Don't duplicate "HKLM\\..\\Uninstall" registry keyDenis Shienkov2019-11-151-15/+9
| | | | | | | | | | | | Change-Id: I3a6f5d200acfec3bf5dd9716be756e15de056279 Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | Skip TestBlackbox::qbsSession when project updates are disabledIvan Komissarov2019-11-151-1/+7
| | | | | | | | | | Change-Id: I2ada7907c2413583d6cb03d22837dfbfba368201 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | GCC: avoid duplicating objects in linker command lineAlberto Mardegan2019-11-1217-0/+252
| | | | | | | | | | | | | | | | | | | | | | Long command lines are especially a problem when building statically in MXE. This commit tries to replicate the logic employed by qmake, where before adding a new object to the command line, all of its previous appearences get removed. Fixes: QBS-1273 Change-Id: I51c843c4a7cfc170ed4fab30deae6c4229690dd0 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | Prepare install-qt script for Qt 5.14 Android multi-abi packagesRichard Weickelt2019-11-071-42/+27
| | | | | | | | | | | | | | | | In order to avoid even more if clauses I took the chance and refactored the URL tests. Change-Id: I66df65020f11d62fd737ebb1cadcd27f0aedf73b Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | Merge branch '1.15' into masterRichard Weickelt2019-11-0523-5/+3164
|\ \ | |/ | | | | Change-Id: Ide94d5c74c5ebd5cde4bf8963cf4449ed026cc39
| * Fix user dependency scannersChristian Kandeler2019-11-053-4/+15
| | | | | | | | | | | | | | | | | | Since commit 9e55ddfa97, we mistakenly passed the output artifact to the scan script, rather than the input artifact. Fixes: QBS-1511 Change-Id: Ieb2a2b3bdf0366ef203e96d578a30a0ef8b1838a Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
| * baremetal: Add USB HID gamepads example for MSP430f5529 chipDenis Shienkov2019-11-0220-1/+3149
| | | | | | | | | | | | | | | | | | This example demonstrates how to create the USB HID device on MSP430f5529 chip (based on MSP430 architecture) using the different toolchains (IAR EW, GCC). Change-Id: Ic4d6a17d3e75e7ccb9b1f3eeaaef9abdf2da896b Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>