diff options
author | Egor Nemtsev <enemtsev@luxoft.com> | 2020-07-22 15:00:36 +0300 |
---|---|---|
committer | Egor Nemtsev <enemtsev@luxoft.com> | 2020-07-22 14:15:06 +0000 |
commit | 5a197ab4fa85ca5368d894e9db0acd1e9d44cc5e (patch) | |
tree | cafaddaa0da47aec5e5aa1c4c4e8d56d3baaffc7 | |
parent | 4e8b40ef55f48bca2c633efe93693d8be8431a7d (diff) |
[sysui] replace onFoo handlers for Connections
- Connections { target: someTarget; onFoo: {} } is now deprecated
and warning is generated. onFoo should be changed to
'function onFoo(params)'
Fixes: AUTOSUITE-1597
Change-Id: I87d93939fa821c53bdf26478baa5444387b1b20e
Reviewed-by: Grigorii Zimin <gzimin@luxoft.com>
50 files changed, 97 insertions, 87 deletions
diff --git a/apps/com.luxoft.vehicle/panels/Vehicle3DPanel.qml b/apps/com.luxoft.vehicle/panels/Vehicle3DPanel.qml index 56767e24..75a35460 100644 --- a/apps/com.luxoft.vehicle/panels/Vehicle3DPanel.qml +++ b/apps/com.luxoft.vehicle/panels/Vehicle3DPanel.qml @@ -147,7 +147,7 @@ Item { target: frameCounter enabled: !root.readyToChanges property int fc: 0 - onTriggered: { + function onTriggered() { if (++fc == 3) { root.readyToChanges = true; } diff --git a/apps/com.luxoft.vehicle/panels/Vehicle3DStudioPanel.qml b/apps/com.luxoft.vehicle/panels/Vehicle3DStudioPanel.qml index 2c31b81e..32a0704b 100644 --- a/apps/com.luxoft.vehicle/panels/Vehicle3DStudioPanel.qml +++ b/apps/com.luxoft.vehicle/panels/Vehicle3DStudioPanel.qml @@ -120,7 +120,7 @@ Item { id: readyToChangeConnection target: studio3D property int fc: 0 - onFrameUpdate: { + function onFrameUpdate() { fc += 1; // skip first 10 frames to be sure that all content is ready if (fc > 10) { diff --git a/apps/com.luxoft.vehicle/views/VehicleView.qml b/apps/com.luxoft.vehicle/views/VehicleView.qml index 5da1d8a5..644bd2ba 100644 --- a/apps/com.luxoft.vehicle/views/VehicleView.qml +++ b/apps/com.luxoft.vehicle/views/VehicleView.qml @@ -99,7 +99,9 @@ Item { Connections { target: vehicle3DPanelLoader.item - onLastCameraAngleChanged: root.store.cameraAngleView = target.lastCameraAngle + function onLastCameraAngleChanged() { + root.store.cameraAngleView = target.lastCameraAngle; + } } VehicleProxyPanel { diff --git a/apps/com.pelagicore.apps.settings/views/SettingsView.qml b/apps/com.pelagicore.apps.settings/views/SettingsView.qml index c4605b3b..c19f44fa 100644 --- a/apps/com.pelagicore.apps.settings/views/SettingsView.qml +++ b/apps/com.pelagicore.apps.settings/views/SettingsView.qml @@ -172,7 +172,7 @@ Control { Connections { target: wifi - onCredentialsRequested: { + function onCredentialsRequested(ssid) { wifiPopup.ssid = ssid; wifiPopup.width = Qt.binding(() => wifiPanel.wifiPopupWidth); wifiPopup.height = Qt.binding(() => wifiPanel.wifiPopupHeight); diff --git a/apps/com.pelagicore.calendar/panels/+lucee/CalendarWidgetPanel.qml b/apps/com.pelagicore.calendar/panels/+lucee/CalendarWidgetPanel.qml index aa8839c6..cb7f351c 100644 --- a/apps/com.pelagicore.calendar/panels/+lucee/CalendarWidgetPanel.qml +++ b/apps/com.pelagicore.calendar/panels/+lucee/CalendarWidgetPanel.qml @@ -152,7 +152,7 @@ Item { Connections { target: root - onDateClicked: { + function onDateClicked() { weatherIcon.randomIndex = Math.floor((Math.random() * (3)) + 0); } } diff --git a/apps/com.pelagicore.calendar/panels/CalendarMaximizedPanel.qml b/apps/com.pelagicore.calendar/panels/CalendarMaximizedPanel.qml index 5cb2d2d8..6eee833c 100644 --- a/apps/com.pelagicore.calendar/panels/CalendarMaximizedPanel.qml +++ b/apps/com.pelagicore.calendar/panels/CalendarMaximizedPanel.qml @@ -219,14 +219,16 @@ Item { Repeater { model: 4 Image { + id: weatherIcon + width: Sizes.dp(80) height: Sizes.dp(80) fillMode: Image.PreserveAspectFit Connections { target: root - onDateClicked: { - randomIndex = Math.floor((Math.random() * (3)) + 0); + function onDateClicked() { + weatherIcon.randomIndex = Math.floor((Math.random() * (3)) + 0); } } @@ -255,12 +257,14 @@ Item { delegatedItemWidth: eventList.width interactive: false delegate: EventListItem { + id: item + property int randomIndex: Math.floor((Math.random() * (8)) + 0) Connections { target: root - onDateClicked: { - randomIndex = Math.floor((Math.random() * (8)) + 0); + function onDateClicked() { + item.randomIndex = Math.floor((Math.random() * (8)) + 0); } } diff --git a/apps/com.pelagicore.climate/controls/TemperatureSlider.qml b/apps/com.pelagicore.climate/controls/TemperatureSlider.qml index d1da8c8b..a92303ca 100644 --- a/apps/com.pelagicore.climate/controls/TemperatureSlider.qml +++ b/apps/com.pelagicore.climate/controls/TemperatureSlider.qml @@ -45,8 +45,8 @@ Slider { Connections { target: root - onPressedChanged: { - if (!pressed) + function onPressedChanged() { + if (!root.pressed) root.sliderReleased() } } diff --git a/apps/com.pelagicore.climate/panels/ClimateContentPanel.qml b/apps/com.pelagicore.climate/panels/ClimateContentPanel.qml index 506348fa..e7ab2def 100644 --- a/apps/com.pelagicore.climate/panels/ClimateContentPanel.qml +++ b/apps/com.pelagicore.climate/panels/ClimateContentPanel.qml @@ -147,7 +147,7 @@ Item { Connections { target: root.store ? root.store.leftSeat : null - onValueChanged: { + function onValueChanged() { if (!leftTempSlider.pressed) { leftTempSlider.value = target.value } @@ -171,7 +171,7 @@ Item { Connections { target: root.store ? root.store.rightSeat : null - onValueChanged: { + function onValueChanged() { if (!rightTempSlider.pressed) { rightTempSlider.value = target.value } diff --git a/apps/com.pelagicore.climate/stores/ClimateStore.qml b/apps/com.pelagicore.climate/stores/ClimateStore.qml index 0a192006..7948a391 100644 --- a/apps/com.pelagicore.climate/stores/ClimateStore.qml +++ b/apps/com.pelagicore.climate/stores/ClimateStore.qml @@ -195,7 +195,7 @@ QtObject { property var conns: Connections { target: climateControl - onAirflowDirectionsChanged: airflow.updateProperties() + function onAirflowDirectionsChanged() { airflow.updateProperties() } } function updateProperties() { diff --git a/apps/com.pelagicore.downloads/controls/DownloadAppList.qml b/apps/com.pelagicore.downloads/controls/DownloadAppList.qml index f082f3e5..6a0ea71c 100644 --- a/apps/com.pelagicore.downloads/controls/DownloadAppList.qml +++ b/apps/com.pelagicore.downloads/controls/DownloadAppList.qml @@ -99,7 +99,9 @@ ListView { Connections { target: d - onInstalledPackagesChanged: { + function onInstalledPackagesChanged(isPackageInstalledByPackageControllerFunc, + isPackageBuiltInFunc, + getInstalledPackageSizeTextFunc) { // functions are passed as parameters to signal model.isInstalled = isPackageInstalledByPackageControllerFunc(model.id); if (isInstalled) { diff --git a/apps/com.pelagicore.downloads/stores/DownloadsStates.qml b/apps/com.pelagicore.downloads/stores/DownloadsStates.qml index 7c9d96ae..6b558aab 100644 --- a/apps/com.pelagicore.downloads/stores/DownloadsStates.qml +++ b/apps/com.pelagicore.downloads/stores/DownloadsStates.qml @@ -184,7 +184,7 @@ DSM.StateMachine { Connections { target: appStoreConfig - onLoginFailed: { + function onLoginFailed() { connectedErrorState.errorText = qsTr("Login Failed"); } } @@ -223,7 +223,7 @@ DSM.StateMachine { Connections { target: jsonCategoryModel - onStatusChanged: { + function onStatusChanged() { if (jsonCategoryModel.status === "error") connectedErrorState.errorText = qsTr("Fetching categories error"); } @@ -277,7 +277,7 @@ DSM.StateMachine { Connections { target: jsonAppModel - onStatusChanged: { + function onStatusChanged() { if (jsonAppModel.status === "error") connectedErrorState.errorText = qsTr("Fetching apps error"); } diff --git a/apps/com.pelagicore.downloads/stores/DownloadsStore.qml b/apps/com.pelagicore.downloads/stores/DownloadsStore.qml index ee9ab822..b73880aa 100644 --- a/apps/com.pelagicore.downloads/stores/DownloadsStore.qml +++ b/apps/com.pelagicore.downloads/stores/DownloadsStore.qml @@ -203,8 +203,10 @@ Item { Connections { target: PackageManager - onTaskProgressChanged: root.currentInstallationProgress = progress - onTaskFailed: { + function onTaskProgressChanged(taskId, progress) { + root.currentInstallationProgress = progress + } + function onTaskFailed(taskId) { var packageId = PackageManager.taskPackageId(taskId); var icon = PackageManager.package("com.pelagicore.downloads").icon; var pkg = null; @@ -230,7 +232,7 @@ Item { currentInstallationProgress = 0.0; } - onTaskFinished: { + function onTaskFinished(taskId) { var packageId = PackageManager.taskPackageId(taskId); var icon = PackageManager.package("com.pelagicore.downloads").icon; var pkg = null; diff --git a/apps/com.pelagicore.downloads/views/DownloadsView.qml b/apps/com.pelagicore.downloads/views/DownloadsView.qml index 212ecf48..6de543eb 100644 --- a/apps/com.pelagicore.downloads/views/DownloadsView.qml +++ b/apps/com.pelagicore.downloads/views/DownloadsView.qml @@ -215,7 +215,7 @@ Item { Connections { target: root.store - onInstalledPackagesChanged: { + function onInstalledPackagesChanged() { // update states of app items, pass functions to update function appList.refreshAppsInfo(root.store.isPackageInstalledByPackageController, root.store.isPackageBuiltIn, @@ -333,7 +333,7 @@ Item { Connections { target: root - onStateChanged: { updateStatesList(); } + function onStateChanged() { updateStatesList(); } } } diff --git a/apps/com.pelagicore.map/Main.qml b/apps/com.pelagicore.map/Main.qml index d202d2de..830ab006 100644 --- a/apps/com.pelagicore.map/Main.qml +++ b/apps/com.pelagicore.map/Main.qml @@ -167,7 +167,7 @@ QtObject { Connections { target: mainMap.store - onNavigationDemoActiveChanged: { + function onNavigationDemoActiveChanged() { if (mainMap.store.navigationDemoActive) { icMapView.path = mainMap.store.routeModel.get(0).path; icMapView.state = "demo_driving"; diff --git a/apps/com.pelagicore.map/views/MapView.qml b/apps/com.pelagicore.map/views/MapView.qml index 87790d03..2fee8c35 100644 --- a/apps/com.pelagicore.map/views/MapView.qml +++ b/apps/com.pelagicore.map/views/MapView.qml @@ -81,7 +81,7 @@ Item { Connections { target: root.store - onRequestNavigationReceived: { + function onRequestNavigationReceived(address, coord, boundingBox) { root.maximizeMap(); root.store.navigationDemoActive = false; mapBoxPanel.state = "initial"; @@ -96,7 +96,7 @@ Item { mapBoxPanel.state = "destination_selection"; } - onRequestRaiseAppReceived: { root.maximizeMap(); } + function onRequestRaiseAppReceived() { root.maximizeMap(); } } MapBoxPanel { diff --git a/apps/com.pelagicore.music/stores/MusicStore.qml b/apps/com.pelagicore.music/stores/MusicStore.qml index 1054fd4a..a69ef5e3 100644 --- a/apps/com.pelagicore.music/stores/MusicStore.qml +++ b/apps/com.pelagicore.music/stores/MusicStore.qml @@ -145,7 +145,7 @@ Store { property Connections con: Connections { target: player.playQueue - onRowsInserted: { + function onRowsInserted(parentIndex, first, last) { console.log(Logging.apps, "Music Queue / Playlist Row Inserted: ", first); player.playQueue.currentIndex = first; } diff --git a/apps/com.pelagicore.music/views/+lucee/MusicView.qml b/apps/com.pelagicore.music/views/+lucee/MusicView.qml index 7696afaf..9362682f 100644 --- a/apps/com.pelagicore.music/views/+lucee/MusicView.qml +++ b/apps/com.pelagicore.music/views/+lucee/MusicView.qml @@ -100,7 +100,7 @@ Item { onNextClicked: root.store.nextSong() Connections { target: store - onSongModelPopulated: { artAndTitlesBlock.populateModel(); } + function onSongModelPopulated() { artAndTitlesBlock.populateModel(); } } } diff --git a/apps/com.pelagicore.music/views/+lucee/WidgetContentView.qml b/apps/com.pelagicore.music/views/+lucee/WidgetContentView.qml index c4032628..cd824bb9 100644 --- a/apps/com.pelagicore.music/views/+lucee/WidgetContentView.qml +++ b/apps/com.pelagicore.music/views/+lucee/WidgetContentView.qml @@ -71,7 +71,7 @@ Item { onNextClicked: store.nextSong() Connections { target: store - onSongModelPopulated: { artAndTitlesBlock.populateModel(); } + function onSongModelPopulated() { artAndTitlesBlock.populateModel(); } } } diff --git a/apps/com.pelagicore.music/views/WidgetContentView.qml b/apps/com.pelagicore.music/views/WidgetContentView.qml index 75b7f77b..c1ab5c80 100644 --- a/apps/com.pelagicore.music/views/WidgetContentView.qml +++ b/apps/com.pelagicore.music/views/WidgetContentView.qml @@ -119,7 +119,7 @@ Item { onNextClicked: root.store.nextSong() Connections { target: root.store - onSongModelPopulated: { artAndTitlesBlock.populateModel(); } + function onSongModelPopulated() { artAndTitlesBlock.populateModel(); } } } diff --git a/apps/com.theqtcompany.cluster/panels/GaugesPanel3D.qml b/apps/com.theqtcompany.cluster/panels/GaugesPanel3D.qml index fef9b7c7..849a64c2 100644 --- a/apps/com.theqtcompany.cluster/panels/GaugesPanel3D.qml +++ b/apps/com.theqtcompany.cluster/panels/GaugesPanel3D.qml @@ -194,13 +194,13 @@ Item { Connections { target: root - onLightThemeVisibleChanged: { + function onLightThemeVisibleChanged() { if (!changeGaugesMainColorAnimation.running && !changeThemeAnimation.running) { changeThemeAnimation.start() } } - onGaugesMainColorChanged: { + function onGaugesMainColorChanged() { if (!changeGaugesMainColorAnimation.running && !changeThemeAnimation.running) { changeGaugesMainColorAnimation.start(); } diff --git a/dev/apps/com.pelagicore.sheets/components/NotificationPanel.qml b/dev/apps/com.pelagicore.sheets/components/NotificationPanel.qml index ce533e41..5155df77 100644 --- a/dev/apps/com.pelagicore.sheets/components/NotificationPanel.qml +++ b/dev/apps/com.pelagicore.sheets/components/NotificationPanel.qml @@ -119,12 +119,12 @@ Item { } Connections { target: appRequestNotiButton.notification5 - onActionTriggered: { + function onActionTriggered() { IntentClient.sendIntentRequest("show-destination", "com.pelagicore.map" , {"destination": "Polis Park Kaningos Athens"}); appRequestNotiButton.notification5.actionAccepted = true; } - onVisibleChanged: { + function onVisibleChanged() { if (!appRequestNotiButton.notification5.visible && !appRequestNotiButton.notification5.actionAccepted) { //if action is not accepted, show warning // it's sticky, so first hide it to be able to show it again diff --git a/doc/src/neptune3ui-application-requests.qdoc b/doc/src/neptune3ui-application-requests.qdoc index 34d9ca21..0c059766 100644 --- a/doc/src/neptune3ui-application-requests.qdoc +++ b/doc/src/neptune3ui-application-requests.qdoc @@ -86,7 +86,7 @@ Connections { target: ApplicationInterface //handle here all specific app behavior - onOpenDocument: { + function onOpenDocument: { //process documentUrl "getmeto/Donald Weese Ct, Las Vegas" } } diff --git a/imports_shared/shared/utils/Cursor.qml b/imports_shared/shared/utils/Cursor.qml index 00162780..0ebdd397 100644 --- a/imports_shared/shared/utils/Cursor.qml +++ b/imports_shared/shared/utils/Cursor.qml @@ -88,10 +88,10 @@ Loader { Connections { target: item - onActivated: { + function onActivated() { root.activated(); } - onPressAndHold: { + function onPressAndHold() { root.pressAndHold(); } } diff --git a/imports_shared/shared/utils/CursorManagement.qml b/imports_shared/shared/utils/CursorManagement.qml index ebfc174c..ea0a2b01 100644 --- a/imports_shared/shared/utils/CursorManagement.qml +++ b/imports_shared/shared/utils/CursorManagement.qml @@ -80,10 +80,10 @@ Item { Connections { target: (parent.pressed !== undefined) ? parent : null - onPressed: { + function onPressed() { pressAndHoldSim.start(); } - onPressedChanged: { + function onPressedChanged() { root.pressed = parent.pressed; } } diff --git a/imports_system/system/controls/AbstractPopupItem.qml b/imports_system/system/controls/AbstractPopupItem.qml index e290bb41..3927456e 100644 --- a/imports_system/system/controls/AbstractPopupItem.qml +++ b/imports_system/system/controls/AbstractPopupItem.qml @@ -100,7 +100,7 @@ Control { Connections { target: parent ? parent : null ignoreUnknownSignals: true - onOverlayClicked: { + function onOverlayClicked() { root.closeHandler() } } diff --git a/imports_system/system/controls/PopupItemLoader.qml b/imports_system/system/controls/PopupItemLoader.qml index ca33a873..5c87b0e4 100644 --- a/imports_system/system/controls/PopupItemLoader.qml +++ b/imports_system/system/controls/PopupItemLoader.qml @@ -64,7 +64,7 @@ Loader { Connections { target: item - onClosed: { + function onClosed() { root.closed(); } } diff --git a/imports_system/system/models/application/ApplicationInfo.qml b/imports_system/system/models/application/ApplicationInfo.qml index 12fa5ba3..a925fc71 100644 --- a/imports_system/system/models/application/ApplicationInfo.qml +++ b/imports_system/system/models/application/ApplicationInfo.qml @@ -198,7 +198,7 @@ QtObject { target: root.application enabled: target != null ignoreUnknownSignals: true - onRunStateChanged: { + function onRunStateChanged() { if (root.application.runState === ApplicationObject.NotRunning) { d.startCallTime = null; } @@ -209,7 +209,7 @@ QtObject { target: d.window && d.window.waylandSurface ? d.window.waylandSurface : null enabled: target != null && d.windowFirstFrameTime === null ignoreUnknownSignals: true - onRedraw: { + function onRedraw() { d.windowFirstFrameTime = Date.now(); } } @@ -218,7 +218,7 @@ QtObject { target: d.icWindow && d.icWindow.waylandSurface ? d.icWindow.waylandSurface : null enabled: target != null && d.icWindowFirstFrameTime === null ignoreUnknownSignals: true - onRedraw: { + function onRedraw() { d.icWindowFirstFrameTime = Date.now(); } } diff --git a/imports_system/system/models/application/ApplicationModel.qml b/imports_system/system/models/application/ApplicationModel.qml index 3f1a903d..b28e4a23 100644 --- a/imports_system/system/models/application/ApplicationModel.qml +++ b/imports_system/system/models/application/ApplicationModel.qml @@ -445,8 +445,8 @@ ListModel { property var appManConns: Connections { target: ApplicationManager - onApplicationWasActivated: d.reactOnAppActivation(id); - onApplicationRunStateChanged: { + function onApplicationWasActivated(id, aliasId) { d.reactOnAppActivation(id); } + function onApplicationRunStateChanged(id, runState) { var appInfo = root.applicationFromId(id); if (!appInfo) { return; @@ -497,14 +497,14 @@ ListModel { } } - onApplicationAdded: { + function onApplicationAdded(id) { var app = ApplicationManager.application(id); d.appendApplication(app); fillStartListsForCurrentModel(); } - onApplicationAboutToBeRemoved: { + function onApplicationAboutToBeRemoved(id) { var appInfo = null; var index; @@ -537,7 +537,7 @@ ListModel { root.appRemoved(appInfo); } - onShuttingDownChanged: { + function onShuttingDownChanged() { if (ApplicationManager.shuttingDown) { root.shuttingDown(); } @@ -547,7 +547,7 @@ ListModel { property var winManConns: Connections { target: WindowManager - onWindowAdded: { + function onWindowAdded(window) { var appInfo = applicationFromId(window.application.id); var isRegularApp = !!appInfo && !root.isSystemApp(appInfo); @@ -590,7 +590,7 @@ ListModel { } } - onWindowAboutToBeRemoved: { + function onWindowAboutToBeRemoved(window) { var appInfo = applicationFromId(window.application.id); if (!appInfo) { if (d.isInstrumentClusterApp(window.application)) { @@ -613,7 +613,7 @@ ListModel { } } - onWindowPropertyChanged: { + function onWindowPropertyChanged(window, name, value) { var appInfo = applicationFromId(window.application.id); switch (name) { case "activationCount": diff --git a/imports_system/system/models/notification/NotificationModel.qml b/imports_system/system/models/notification/NotificationModel.qml index 32841184..ba2eca9c 100644 --- a/imports_system/system/models/notification/NotificationModel.qml +++ b/imports_system/system/models/notification/NotificationModel.qml @@ -46,11 +46,11 @@ QtObject { readonly property Connections notificationManagerConnection: Connections { target: root.model - onNotificationAdded: { + function onNotificationAdded() { root.notificationAdded(); } - onNotificationAboutToBeRemoved: { + function onNotificationAboutToBeRemoved() { root.notificationRemoved(); } } diff --git a/imports_system/system/requests/ApplicationRequestHandler.qml b/imports_system/system/requests/ApplicationRequestHandler.qml index da544f57..9ca8d73c 100644 --- a/imports_system/system/requests/ApplicationRequestHandler.qml +++ b/imports_system/system/requests/ApplicationRequestHandler.qml @@ -111,7 +111,7 @@ QtObject { readonly property var appManConns: Connections { target: ApplicationManager - onOpenUrlRequested: { + function onOpenUrlRequested(requestId, url, mimeType, possibleAppIds) { sendRequest(requestId, possibleAppIds); } } diff --git a/plugins/controls/ListItemSwitch.qml b/plugins/controls/ListItemSwitch.qml index 35c30053..32b2dbb4 100644 --- a/plugins/controls/ListItemSwitch.qml +++ b/plugins/controls/ListItemSwitch.qml @@ -122,7 +122,7 @@ ListItemBasic { Connections { target: root - onClicked: switchDelegate.toggle() + function onClicked() { switchDelegate.toggle() } } } } diff --git a/plugins/controls/ToolsColumn.qml b/plugins/controls/ToolsColumn.qml index 1faadeee..7b876272 100644 --- a/plugins/controls/ToolsColumn.qml +++ b/plugins/controls/ToolsColumn.qml @@ -190,7 +190,7 @@ ListView { Connections { target: root.model - onCountChanged: { + function onCountChanged() { if (currentIndex > 0 && model.count <= currentIndex) { currentIndex = 0; } diff --git a/src/neptune-cluster-app/apps/com.pelagicore.map-ic/Main.qml b/src/neptune-cluster-app/apps/com.pelagicore.map-ic/Main.qml index be962191..ac56bd47 100644 --- a/src/neptune-cluster-app/apps/com.pelagicore.map-ic/Main.qml +++ b/src/neptune-cluster-app/apps/com.pelagicore.map-ic/Main.qml @@ -80,7 +80,7 @@ Item { Connections { target: store - onNavigationDemoActiveChanged: { + function onNavigationDemoActiveChanged() { if (store.navigationDemoActive) { icMapView.path = store.routePoints; icMapView.state = "demo_driving"; diff --git a/src/neptune-cluster-app/main.qml b/src/neptune-cluster-app/main.qml index 7f89c5c2..51cfd694 100644 --- a/src/neptune-cluster-app/main.qml +++ b/src/neptune-cluster-app/main.qml @@ -57,8 +57,8 @@ Window { Connections { target: clrst.uiSettings - onThemeChanged: root.Style.theme = clrst.uiSettings.theme - onAccentColorChanged: root.Style.accentColor = clrst.uiSettings.accentColor + function onThemeChanged() { root.Style.theme = clrst.uiSettings.theme } + function onAccentColorChanged() { root.Style.accentColor = clrst.uiSettings.accentColor } } MockedWindows { diff --git a/src/remotesettings/app/main.qml b/src/remotesettings/app/main.qml index 95d0b80f..d677b1e4 100644 --- a/src/remotesettings/app/main.qml +++ b/src/remotesettings/app/main.qml @@ -143,7 +143,7 @@ ApplicationWindow { Connections { target: client - onServerUrlChanged: { + function onServerUrlChanged() { if (client.serverUrl.toString().length) connectionDialog.url = client.serverUrl.toString(); else @@ -153,7 +153,7 @@ ApplicationWindow { Connections { target: client - onConnectedChanged: { + function onConnectedChanged() { if (client.connected) connectionDialog.close(); } diff --git a/sysui/about/AboutApps.qml b/sysui/about/AboutApps.qml index af70ff30..efaa7d61 100644 --- a/sysui/about/AboutApps.qml +++ b/sysui/about/AboutApps.qml @@ -86,7 +86,7 @@ Item { Connections { target: applicationModel ignoreUnknownSignals: true - onAppRemoved: { + function onAppRemoved(appInfo) { runningAppsModel.removeAppInfo(appInfo) } } diff --git a/sysui/centerconsole/ApplicationPopup.qml b/sysui/centerconsole/ApplicationPopup.qml index 1d7ea157..45c082f4 100644 --- a/sysui/centerconsole/ApplicationPopup.qml +++ b/sysui/centerconsole/ApplicationPopup.qml @@ -59,7 +59,7 @@ PopupItem { Connections { target: root // reset popup parameters on scale change - onHeightChanged: { + function onHeightChanged() { if ("open" === root.state) { root.originItemX = root.window.windowProperty("originItemX") root.originItemY = root.window.windowProperty("originItemY") diff --git a/sysui/centerconsole/ApplicationPopups.qml b/sysui/centerconsole/ApplicationPopups.qml index ea219edf..5df2a2d4 100644 --- a/sysui/centerconsole/ApplicationPopups.qml +++ b/sysui/centerconsole/ApplicationPopups.qml @@ -60,7 +60,7 @@ Item { Connections { target: model.window - onContentStateChanged: { + function onContentStateChanged() { if (model.window.contentState === WindowObject.NoSurface) { // client has closed his PopupWindow. Animate accordingly. appPopup.close(); diff --git a/sysui/centerconsole/CenterConsoleWindow.qml b/sysui/centerconsole/CenterConsoleWindow.qml index f23966e1..b2d42505 100644 --- a/sysui/centerconsole/CenterConsoleWindow.qml +++ b/sysui/centerconsole/CenterConsoleWindow.qml @@ -88,7 +88,7 @@ Window { , root.store.settingsStore.defaultAutostartApps) readonly property string autorecoverApps: root.store.settingsStore.value("autorecoverApps" , root.store.settingsStore.defaultAutorecoverApps) - onFrameSwapped: { + function onFrameSwapped() { /* The UI is loaded in two steps This is done in order to ensure that something is rendered on the screen as diff --git a/sysui/centerconsole/GamePadController.qml b/sysui/centerconsole/GamePadController.qml index ded6bb1a..9be31f9c 100644 --- a/sysui/centerconsole/GamePadController.qml +++ b/sysui/centerconsole/GamePadController.qml @@ -75,7 +75,7 @@ Item { Connections { target: GamepadManager - onGamepadConnected: { + function onGamepadConnected(deviceId) { gamepad1.deviceId = deviceId } } diff --git a/sysui/centerconsole/WidgetDrawer.qml b/sysui/centerconsole/WidgetDrawer.qml index a9334dc9..41b5f385 100644 --- a/sysui/centerconsole/WidgetDrawer.qml +++ b/sysui/centerconsole/WidgetDrawer.qml @@ -88,7 +88,7 @@ Item { Connections { target: handl.drag - onActiveChanged: { + function onActiveChanged() { if (handl.drag.active) { d.lastX = root.x; d.direction = 0; diff --git a/sysui/home/AddWidgetPopupLoader.qml b/sysui/home/AddWidgetPopupLoader.qml index c619b151..7aac2f23 100644 --- a/sysui/home/AddWidgetPopupLoader.qml +++ b/sysui/home/AddWidgetPopupLoader.qml @@ -57,7 +57,7 @@ Loader { Connections { target: item - onClosed: { + function onClosed() { root.closed(); } } diff --git a/sysui/instrumentcluster/ApplicationICWindows.qml b/sysui/instrumentcluster/ApplicationICWindows.qml index b1b9e149..ca1bcb47 100644 --- a/sysui/instrumentcluster/ApplicationICWindows.qml +++ b/sysui/instrumentcluster/ApplicationICWindows.qml @@ -62,7 +62,7 @@ Item { delegate: QtObject { property var con: Connections { target: model.appInfo - onIcWindowChanged: { + function onIcWindowChanged() { if (model.appInfo.icWindow) { var appInList = false; for (var i = 0; i < applicationICWindowList.count; i++) { diff --git a/sysui/instrumentcluster/InstrumentClusterWindow.qml b/sysui/instrumentcluster/InstrumentClusterWindow.qml index 8a9c0688..8a883117 100644 --- a/sysui/instrumentcluster/InstrumentClusterWindow.qml +++ b/sysui/instrumentcluster/InstrumentClusterWindow.qml @@ -101,17 +101,17 @@ Window { Connections { target: root enabled: root.clusterStore.qsrEnabled - onXChanged: sendWindowStateToSafeUI(); - onYChanged: sendWindowStateToSafeUI(); - onActiveChanged: sendWindowStateToSafeUI(); + function onXChanged() { sendWindowStateToSafeUI(); } + function onYChanged() { sendWindowStateToSafeUI(); } + function onActiveChanged() { sendWindowStateToSafeUI(); } } Connections { target: uiSlot enabled: root.clusterStore.qsrEnabled - onWidthChanged: sendWindowStateToSafeUI(); - onHeightChanged: sendWindowStateToSafeUI(); - onYChanged: sendWindowStateToSafeUI(); - onXChanged: sendWindowStateToSafeUI(); + function onWidthChanged() { sendWindowStateToSafeUI(); } + function onHeightChanged() { sendWindowStateToSafeUI(); } + function onYChanged() { sendWindowStateToSafeUI(); } + function onXChanged() { sendWindowStateToSafeUI(); } } Item { diff --git a/sysui/launcher/EditableGridView.qml b/sysui/launcher/EditableGridView.qml index 6759e6e6..caa3e444 100644 --- a/sysui/launcher/EditableGridView.qml +++ b/sysui/launcher/EditableGridView.qml @@ -164,7 +164,7 @@ Item { Connections { target: model.appInfo - onActiveChanged: { + function onActiveChanged() { if (model.appInfo.active) { appButton.checked = true; } else { diff --git a/sysui/notification/NotificationCenter.qml b/sysui/notification/NotificationCenter.qml index 3be8d38b..a62c4151 100644 --- a/sysui/notification/NotificationCenter.qml +++ b/sysui/notification/NotificationCenter.qml @@ -209,13 +209,13 @@ Item { Connections { target: root.notificationModel - onCountChanged: { + function onCountChanged() { if (root.notificationModel.count === 0) { root.state = "closed"; } } - onNotificationAdded: { + function onNotificationAdded() { state = "incomingNotification"; notificationShowTimer.stop(); var notification = root.notificationModel.model.get(root.notificationModel.count - 1); @@ -226,7 +226,7 @@ Item { notificationShowTimer.start(); } - onNotificationClosed: { + function onNotificationClosed() { root.state = "closed"; } } diff --git a/sysui/notification/NotificationToast.qml b/sysui/notification/NotificationToast.qml index e44f7f9e..142a352c 100644 --- a/sysui/notification/NotificationToast.qml +++ b/sysui/notification/NotificationToast.qml @@ -55,7 +55,7 @@ NotificationItem { Connections { target: root.notificationModel - onNotificationAdded: { + function onNotificationAdded() { var currentNotification = root.notificationModel.model.get(root.notificationModel.count - 1); priv.notificationId = currentNotification.id; root.notificationIcon = currentNotification.icon; @@ -71,7 +71,7 @@ NotificationItem { } } - onNotificationClosed: { + function onNotificationClosed() { priv.notificationId = -1; } } diff --git a/sysui/stores/MusicAppRequestsIPCStore.qml b/sysui/stores/MusicAppRequestsIPCStore.qml index f3c65407..4e54d234 100644 --- a/sysui/stores/MusicAppRequestsIPCStore.qml +++ b/sysui/stores/MusicAppRequestsIPCStore.qml @@ -73,7 +73,7 @@ ApplicationIPCInterface { property var appmanCnx: Connections { target: ApplicationManager - onApplicationAdded: { + function onApplicationAdded(id) { if (id === "com.pelagicore.spotify") { root.spotifyInstalled = true; } @@ -81,7 +81,7 @@ ApplicationIPCInterface { root.webradioInstalled = true; } } - onApplicationAboutToBeRemoved: { + function onApplicationAboutToBeRemoved(id) { if (id === "com.pelagicore.spotify") { root.spotifyInstalled = false; } diff --git a/sysui/stores/RootStore.qml b/sysui/stores/RootStore.qml index e8f6c191..85791d98 100644 --- a/sysui/stores/RootStore.qml +++ b/sysui/stores/RootStore.qml @@ -201,7 +201,7 @@ Store { readonly property Connections instentServerConnection: Connections { target: IntentServer - onDisambiguationRequest: { + function onDisambiguationRequest(requestId, potentialIntents, parameters) { //process "activate-app" intent sent with part of app name (guess-app) as parameter if (potentialIntents.length > 0 && potentialIntents[0].intentId === "activate-app") { var guess_app = parameters["guess-app"]; diff --git a/tests/dummyimports/QtApplicationManager/SystemUI/WindowManager.qml b/tests/dummyimports/QtApplicationManager/SystemUI/WindowManager.qml index e24c34b4..983f64c5 100644 --- a/tests/dummyimports/QtApplicationManager/SystemUI/WindowManager.qml +++ b/tests/dummyimports/QtApplicationManager/SystemUI/WindowManager.qml @@ -40,7 +40,7 @@ QtObject { property var surfaceItems: [] property Connections conn: Connections { target: ApplicationManager - onEmitSurface: { + function onEmitSurface(index, item) { surfaceItems[index] = item root.surfaceItemReady(index, item) } |