diff options
author | Mark Wielaard <mjw@redhat.com> | 2011-03-17 12:38:45 +0100 |
---|---|---|
committer | Mark Wielaard <mjw@redhat.com> | 2011-03-17 12:38:45 +0100 |
commit | 2a511cf5310f15e18caeb345ff2a2f8d0f5ca878 (patch) | |
tree | be21975dabed22229f3dcfdba93268f5f11fb4e9 | |
parent | be15b856ba63221aa0fc2fc05eb0f3dd36963670 (diff) |
Add check_self_referential_die pass to dwarflint.upstream/mjw/check_self_referential_die
-rw-r--r-- | dwarflint/Makefile.am | 1 | ||||
-rw-r--r-- | dwarflint/check_self_referential_die.cc | 86 |
2 files changed, 87 insertions, 0 deletions
diff --git a/dwarflint/Makefile.am b/dwarflint/Makefile.am index 7c0a9b2f..821bc3b0 100644 --- a/dwarflint/Makefile.am +++ b/dwarflint/Makefile.am @@ -82,6 +82,7 @@ dwarflint_SOURCES = \ check_matching_ranges.cc \ check_nodebug.cc \ check_range_out_of_scope.cc \ + check_self_referential_die.cc \ locstats.cc \ lowlevel_checks.cc lowlevel_checks.hh \ \ diff --git a/dwarflint/check_self_referential_die.cc b/dwarflint/check_self_referential_die.cc new file mode 100644 index 00000000..1f1dfe8f --- /dev/null +++ b/dwarflint/check_self_referential_die.cc @@ -0,0 +1,86 @@ +/* Pedantic checking of DWARF files. + Copyright (C) 2011 Red Hat, Inc. + This file is part of Red Hat elfutils. + + Red Hat elfutils is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by the + Free Software Foundation; version 2 of the License. + + Red Hat elfutils is distributed in the hope that it will be useful, but + WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + General Public License for more details. + + You should have received a copy of the GNU General Public License along + with Red Hat elfutils; if not, write to the Free Software Foundation, + Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301 USA. + + Red Hat elfutils is an included package of the Open Invention Network. + An included package of the Open Invention Network is a package for which + Open Invention Network licensees cross-license their patents. No patent + license is granted, either expressly or impliedly, by designation as an + included package. Should you wish to participate in the Open Invention + Network licensing program, please visit www.openinventionnetwork.com + <http://www.openinventionnetwork.com>. */ + +#ifdef HAVE_CONFIG_H +# include <config.h> +#endif + +#include "highlevel_check.hh" +#include "../src/dwarfstrings.h" +#include "all-dies-it.hh" +#include "pri.hh" +#include "messages.hh" +#include <map> + +using elfutils::dwarf; + +namespace +{ + class check_self_referential_die + : public highlevel_check<check_self_referential_die> + { + public: + static checkdescriptor const *descriptor () + { + static checkdescriptor cd + (checkdescriptor::create ("check_self_referential_die") + .inherit<highlevel_check<check_self_referential_die> > () + .description ( +"A reference attribute referencing the DIE itself is suspicious.\n" +"One example is a DW_AT_containing_type pointing to itself.\n" +" https://fedorahosted.org/pipermail/elfutils-devel/2011-February/001794.html\n" + )); + return &cd; + } + + explicit check_self_referential_die (checkstack &stack, dwarflint &lint) + : highlevel_check<check_self_referential_die> (stack, lint) + { + for (all_dies_iterator<dwarf> it = all_dies_iterator<dwarf> (dw); + it != all_dies_iterator<dwarf> (); ++it) + { + dwarf::debug_info_entry const &die = *it; + for (dwarf::debug_info_entry::attributes_type::const_iterator + at = die.attributes ().begin (); + at != die.attributes ().end (); ++at) + { + dwarf::attr_value const &val = (*at).second; + if (val.what_space () == dwarf::VS_reference) + { + dwarf::debug_info_entry ref = *val.reference (); + if (ref.identity () == die.identity ()) + wr_message (to_where (die), cat (mc_impact_3, + mc_acc_suboptimal, + mc_die_rel)) + << "attribute " << dwarf::attributes::name ((*at).first) + << " references DIE itself." << std::endl; + } + } + } + } + }; + + reg<check_self_referential_die> reg; +} |