diff options
| author | Christian Stenger <christian.stenger@qt.io> | 2020-09-03 11:23:59 +0200 |
|---|---|---|
| committer | Christian Stenger <christian.stenger@qt.io> | 2020-09-04 04:32:49 +0000 |
| commit | f9600b733557b4b29d0ab9f230cc9d87887d3039 (patch) | |
| tree | 935e17142ec9a08d5cc91e5e1f78081df25941f6 | |
| parent | f849319d118d9d7cfd206e30d9a198a427bc24bb (diff) | |
CMakePM: Fix removing cmake tools
The id might be destroyed with its parent before trying to
reference it again and put it into the list.
Change-Id: Ic7bb053293b24f0f0109a1c6479f73b7cbec2dc0
Reviewed-by: hjk <hjk@qt.io>
| -rw-r--r-- | src/plugins/cmakeprojectmanager/cmakesettingspage.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/cmakeprojectmanager/cmakesettingspage.cpp b/src/plugins/cmakeprojectmanager/cmakesettingspage.cpp index 61e3dba76f..e26a0cb970 100644 --- a/src/plugins/cmakeprojectmanager/cmakesettingspage.cpp +++ b/src/plugins/cmakeprojectmanager/cmakesettingspage.cpp @@ -343,8 +343,8 @@ void CMakeToolItemModel::removeCMakeTool(const Utils::Id &id) CMakeToolTreeItem *treeItem = cmakeToolItem(id); QTC_ASSERT(treeItem, return); - destroyItem(treeItem); m_removedItems.append(id); + destroyItem(treeItem); } void CMakeToolItemModel::apply() |