diff options
| author | Jarek Kobus <jaroslaw.kobus@qt.io> | 2022-07-05 13:07:37 +0200 |
|---|---|---|
| committer | Jarek Kobus <jaroslaw.kobus@qt.io> | 2022-07-05 11:47:17 +0000 |
| commit | 96c5a8a789d0fc24696e8f893261f476c120d412 (patch) | |
| tree | 0ac1ed599ae76ef69c8ce90730d254ec00b4e0d2 | |
| parent | c7aa3a960577cb4f9ec7fa4cdf53366152d1bc9d (diff) | |
PipSupport: Connect to watcher before setting a future
In order to avoid runtime warning:
"QFutureWatcher::connect: connecting after calling
setFuture() is likely to produce race".
Change-Id: I921396628e5615e7c2d87045d2e787388dbddcc6
Reviewed-by: David Schulz <david.schulz@qt.io>
| -rw-r--r-- | src/plugins/python/pipsupport.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/plugins/python/pipsupport.cpp b/src/plugins/python/pipsupport.cpp index b290f75d2e..3d479f871b 100644 --- a/src/plugins/python/pipsupport.cpp +++ b/src/plugins/python/pipsupport.cpp @@ -50,13 +50,12 @@ static constexpr char pipInstallTaskId[] = "Python::pipInstallTask"; PipInstallTask::PipInstallTask(const FilePath &python) : m_python(python) { - m_watcher.setFuture(m_future.future()); - connect(&m_process, &QtcProcess::done, this, &PipInstallTask::handleDone); connect(&m_process, &QtcProcess::readyReadStandardError, this, &PipInstallTask::handleError); connect(&m_process, &QtcProcess::readyReadStandardOutput, this, &PipInstallTask::handleOutput); connect(&m_killTimer, &QTimer::timeout, this, &PipInstallTask::cancel); connect(&m_watcher, &QFutureWatcher<void>::canceled, this, &PipInstallTask::cancel); + m_watcher.setFuture(m_future.future()); } void PipInstallTask::setPackage(const PipPackage &package) |