aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlessandro Portale <alessandro.portale@qt.io>2022-07-01 15:02:07 +0200
committerAlessandro Portale <alessandro.portale@qt.io>2022-07-04 08:26:04 +0000
commitc899793b373042b58f17d8eca01168aa9d6b99e3 (patch)
tree723811e6c765f89fbd4951d8f6c7a594d14f5ea5
parent9dc1fb3381b1c94a880c66b5abdef6359d7f83a8 (diff)
Android: Fix version mapping from sdk_definitions.json
- Support multi-digit values for version ranges, via "+" in the RegExp - Turn the RegExp expression into a raw string for easier reading - Fix shortVersion (Maj.Min.-1) handling by appending the ".-1" - Explicitly define the Patch number range for 5.15 in sdk_definitions Change-Id: Icf22f2b4f865b4d5bcff48569aa58137294129ce Reviewed-by: hjk <hjk@qt.io> Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
-rw-r--r--share/qtcreator/android/sdk_definitions.json2
-rw-r--r--src/plugins/android/androidconfigurations.cpp4
2 files changed, 3 insertions, 3 deletions
diff --git a/share/qtcreator/android/sdk_definitions.json b/share/qtcreator/android/sdk_definitions.json
index 9dd6ee4cae..1c7476763b 100644
--- a/share/qtcreator/android/sdk_definitions.json
+++ b/share/qtcreator/android/sdk_definitions.json
@@ -22,7 +22,7 @@
"ndk_path": "ndk/23.1.7779620"
},
{
- "versions": ["6.3", "6.2", "5.15"],
+ "versions": ["6.3", "6.2", "5.15.[9-20]"],
"sdk_essential_packages": ["build-tools;31.0.0", "ndk;22.1.7171670"],
"ndk_path": "ndk/22.1.7171670"
},
diff --git a/src/plugins/android/androidconfigurations.cpp b/src/plugins/android/androidconfigurations.cpp
index c4942aee3f..642cef0b08 100644
--- a/src/plugins/android/androidconfigurations.cpp
+++ b/src/plugins/android/androidconfigurations.cpp
@@ -344,13 +344,13 @@ void AndroidConfig::parseDependenciesJson()
auto fillQtVersionsRange = [](const QString &shortVersion) {
QList<QtVersionNumber> versions;
- QRegularExpression re("([0-9]\\.[0-9]*\\.)\\[([0-9])\\-([0-9])\\]");
+ const QRegularExpression re(R"(([0-9]\.[0-9]+\.)\[([0-9]+)\-([0-9]+)\])");
QRegularExpressionMatch match = re.match(shortVersion);
if (match.hasMatch() && match.lastCapturedIndex() == 3)
for (int i = match.captured(2).toInt(); i <= match.captured(3).toInt(); ++i)
versions.append(QtVersionNumber(match.captured(1) + QString::number(i)));
else
- versions.append(QtVersionNumber(shortVersion));
+ versions.append(QtVersionNumber(shortVersion + ".-1"));
return versions;
};