diff options
| author | Eike Ziller <eike.ziller@qt.io> | 2020-03-19 16:02:44 +0100 |
|---|---|---|
| committer | Eike Ziller <eike.ziller@qt.io> | 2020-03-23 07:14:27 +0000 |
| commit | 9eceb46739803bb7482e9017cd79df92203ecbad (patch) | |
| tree | a5225bc4dd9bec174a8636f88a6f3e805bd2c420 /scripts | |
| parent | 549b2f60924aafdb9b3f22bdbcd7870afe3ae172 (diff) | |
Fix link on commit sha in about dialog
Passing a URL via defines breaks when trying to "stringify" it.
It would always stop at the first slash.
Instead use a qmake variable directly. That has the additional advantage that
the value isn't passed on each and every compiler command line.
Change-Id: I97a297fbcdee5ea03eb6fa08181c95b1ad2de767
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Diffstat (limited to 'scripts')
| -rwxr-xr-x | scripts/build.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/build.py b/scripts/build.py index ec50a21b8e..3c48136239 100755 --- a/scripts/build.py +++ b/scripts/build.py @@ -131,7 +131,7 @@ def build_qtcreator(args, paths): if ide_revision: cmake_args += ['-DIDE_REVISION=ON', '-DIDE_REVISION_STR=' + ide_revision, - '-DIDE_REVISION_URL_STR=https://code.qt.io/cgit/qt-creator/qt-creator.git/log/?id=' + ide_revision] + '-DIDE_REVISION_URL=https://code.qt.io/cgit/qt-creator/qt-creator.git/log/?id=' + ide_revision] common.check_print_call(cmake_args + [paths.src], paths.build) common.check_print_call(['cmake', '--build', '.'], paths.build) |