aboutsummaryrefslogtreecommitdiffstats
path: root/share
diff options
context:
space:
mode:
authorhjk <hjk@theqtcompany.com>2016-04-13 19:37:31 +0200
committerhjk <hjk@theqtcompany.com>2016-04-14 12:49:59 +0000
commit9425f28865c69be050cba2cd220a753daabc4c10 (patch)
tree6c668c2cd3cc874442d9735fd4627a09be00f2bb /share
parentd0a6f70380925bd84e1b96a345092c9b81b87768 (diff)
Debugger: Hex-Encode LLDB disassembler comment fields
They may contain quotes and possibly other data breaking the transport protocol. Change-Id: I53795bd1de54385e8d9c50088368fdc768db217b Task-number: QTCREATORBUG-15635 Reviewed-by: Alexandru Croitor <alexandru.croitor@theqtcompany.com> Reviewed-by: hjk <hjk@theqtcompany.com>
Diffstat (limited to 'share')
-rw-r--r--share/qtcreator/debugger/lldbbridge.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/share/qtcreator/debugger/lldbbridge.py b/share/qtcreator/debugger/lldbbridge.py
index 08e3689662..6fd697fcc3 100644
--- a/share/qtcreator/debugger/lldbbridge.py
+++ b/share/qtcreator/debugger/lldbbridge.py
@@ -1732,7 +1732,7 @@ class Dumper(DumperBase):
rawData = insn.GetData(lldb.target).uint8s
result += ',rawdata="%s"' % ' '.join(["%02x" % x for x in rawData])
if comment:
- result += ',comment="%s"' % comment
+ result += ',comment="%s"' % self.hexencode(comment)
result += ',offset="%s"}' % (loadAddr - base)
self.reportResult(result + ']', args)