aboutsummaryrefslogtreecommitdiffstats
path: root/share
diff options
context:
space:
mode:
authorThomas Hartmann <thomas.hartmann@qt.io>2020-06-16 17:05:56 +0200
committerTim Jenssen <tim.jenssen@qt.io>2020-06-26 06:48:26 +0000
commit003282c6f5ed89de4bc5a2ddeffdea59286b455f (patch)
treec18f73b6105fdb0bb3e5855623dd3e5c5d95ffa0 /share
parent72302cac4902178e38489c2cc60f4897e9dbc5f1 (diff)
QmlDesigner: Fix crash on puppet
Change-Id: I233d3dab5a509bfd7c9a30c7dcc15dcf8751f456 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Diffstat (limited to 'share')
-rw-r--r--share/qtcreator/qml/qmlpuppet/qml2puppet/instances/objectnodeinstance.cpp12
1 files changed, 8 insertions, 4 deletions
diff --git a/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/objectnodeinstance.cpp b/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/objectnodeinstance.cpp
index 840b71c671..5991e2b28e 100644
--- a/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/objectnodeinstance.cpp
+++ b/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/objectnodeinstance.cpp
@@ -779,7 +779,9 @@ QObject *ObjectNodeInstance::createComponent(const QUrl &componentUrl, QQmlConte
return QmlPrivateGate::createComponent(componentUrl, context);
}
-QObject *ObjectNodeInstance::createCustomParserObject(const QString &nodeSource, const QByteArray &importCode, QQmlContext *context)
+QObject *ObjectNodeInstance::createCustomParserObject(const QString &nodeSource,
+ const QByteArray &importCode,
+ QQmlContext *context)
{
QmlPrivateGate::ComponentCompleteDisabler disableComponentComplete;
Q_UNUSED(disableComponentComplete)
@@ -790,9 +792,11 @@ QObject *ObjectNodeInstance::createCustomParserObject(const QString &nodeSource,
data.prepend(importCode);
component.setData(data, context->baseUrl().resolved(QUrl("createCustomParserObject.qml")));
QObject *object = component.beginCreate(context);
- QmlPrivateGate::tweakObjects(object);
- component.completeCreate();
- QQmlEngine::setObjectOwnership(object, QQmlEngine::CppOwnership);
+ if (object) {
+ QmlPrivateGate::tweakObjects(object);
+ component.completeCreate();
+ QQmlEngine::setObjectOwnership(object, QQmlEngine::CppOwnership);
+ }
if (component.isError()) {
qWarning() << "Error in:" << Q_FUNC_INFO << component.url().toString();