diff options
author | Nikolai Kosjar <nikolai.kosjar@qt.io> | 2017-07-27 10:27:20 +0200 |
---|---|---|
committer | Nikolai Kosjar <nikolai.kosjar@qt.io> | 2017-07-27 08:44:12 +0000 |
commit | ba6939fa90cd17a58e1505a2c73fac026f11efa9 (patch) | |
tree | 7d584bd5d38eb9ceec786a30880ee2501d9d62ea /src/libs/extensionsystem/pluginspec.cpp | |
parent | c78ea5a7ea7bd7f451d5d3c5fcca4920e942e233 (diff) |
Unit tests: Fix ProjectInfoGenerator.* tests
...by adapting to recent mime type changes:
commit e8e46ab553bce9aac9adcaf2ac4ee1207b69ac93
Plugins: Fix that mimetype definition was not valid JSON
Change-Id: Iac416ab481814e4488fac4d818c51c647c1ec349
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Diffstat (limited to 'src/libs/extensionsystem/pluginspec.cpp')
-rw-r--r-- | src/libs/extensionsystem/pluginspec.cpp | 25 |
1 files changed, 3 insertions, 22 deletions
diff --git a/src/libs/extensionsystem/pluginspec.cpp b/src/libs/extensionsystem/pluginspec.cpp index cde1903099..98ab0f8a02 100644 --- a/src/libs/extensionsystem/pluginspec.cpp +++ b/src/libs/extensionsystem/pluginspec.cpp @@ -32,6 +32,7 @@ #include <utils/algorithm.h> #include <utils/qtcassert.h> +#include <utils/stringutils.h> #include <QCoreApplication> #include <QDebug> @@ -631,26 +632,6 @@ static inline QString msgInvalidFormat(const char *key, const QString &content) .arg(QLatin1String(key), content); } -bool PluginSpec::readMultiLineString(const QJsonValue &value, QString *out) -{ - QTC_ASSERT(out, return false); - if (value.isString()) { - *out = value.toString(); - } else if (value.isArray()) { - QJsonArray array = value.toArray(); - QStringList lines; - foreach (const QJsonValue &v, array) { - if (!v.isString()) - return false; - lines.append(v.toString()); - } - *out = lines.join(QLatin1Char('\n')); - } else { - return false; - } - return true; -} - /*! \internal */ @@ -735,7 +716,7 @@ bool PluginSpecPrivate::readMetaData(const QJsonObject &pluginMetaData) copyright = value.toString(); value = metaData.value(QLatin1String(DESCRIPTION)); - if (!value.isUndefined() && !PluginSpec::readMultiLineString(value, &description)) + if (!value.isUndefined() && !Utils::readMultiLineString(value, &description)) return reportError(msgValueIsNotAString(DESCRIPTION)); value = metaData.value(QLatin1String(URL)); @@ -749,7 +730,7 @@ bool PluginSpecPrivate::readMetaData(const QJsonObject &pluginMetaData) category = value.toString(); value = metaData.value(QLatin1String(LICENSE)); - if (!value.isUndefined() && !PluginSpec::readMultiLineString(value, &license)) + if (!value.isUndefined() && !Utils::readMultiLineString(value, &license)) return reportError(msgValueIsNotAMultilineString(LICENSE)); value = metaData.value(QLatin1String(PLATFORM)); |