aboutsummaryrefslogtreecommitdiffstats
path: root/src/libs/qmljs
diff options
context:
space:
mode:
authorEike Ziller <eike.ziller@qt.io>2017-11-07 15:10:36 +0100
committerEike Ziller <eike.ziller@qt.io>2017-11-07 15:10:36 +0100
commita9e4e3608e79f3a03abff7ceea31d9ade36dda7f (patch)
treeed186d69bb1a48319123a1702dacb6ce941e738d /src/libs/qmljs
parent8515fd13e3ceeab3ac1c9b639515655f604ff2cd (diff)
parent83ff62aa13512b0a8f9f46e4eb7d1a7d5745d0fb (diff)
Merge remote-tracking branch 'origin/4.5'
Diffstat (limited to 'src/libs/qmljs')
-rw-r--r--src/libs/qmljs/qmljscheck.cpp17
1 files changed, 11 insertions, 6 deletions
diff --git a/src/libs/qmljs/qmljscheck.cpp b/src/libs/qmljs/qmljscheck.cpp
index 6bc596eacde..42558f65a4a 100644
--- a/src/libs/qmljs/qmljscheck.cpp
+++ b/src/libs/qmljs/qmljscheck.cpp
@@ -1044,15 +1044,20 @@ bool Check::visit(UiPublicMember *ast)
{
if (ast->type == UiPublicMember::Property) {
if (ast->isValid()) {
- const QStringRef name = ast->memberTypeName();
- if (!name.isEmpty() && name.at(0).isLower()) {
- const QString nameS = name.toString();
- if (!isValidBuiltinPropertyType(nameS))
- addMessage(ErrInvalidPropertyType, ast->typeToken, nameS);
+ const QStringRef typeName = ast->memberTypeName();
+ if (!typeName.isEmpty() && typeName.at(0).isLower()) {
+ const QString typeNameS = typeName.toString();
+ if (!isValidBuiltinPropertyType(typeNameS))
+ addMessage(ErrInvalidPropertyType, ast->typeToken, typeNameS);
}
+ const QStringRef name = ast->name;
+
+ if (name == "data")
+ addMessage(ErrInvalidPropertyName, ast->identifierToken, name.toString());
+
// warn about dubious use of var/variant
- if (name == QLatin1String("variant") || name == QLatin1String("var")) {
+ if (typeName == QLatin1String("variant") || typeName == QLatin1String("var")) {
Evaluate evaluator(&_scopeChain);
const Value *init = evaluator(ast->statement);
QString preferredType;