diff options
author | hjk <hjk@qt.io> | 2019-05-08 17:45:02 +0200 |
---|---|---|
committer | hjk <hjk@qt.io> | 2019-05-09 15:12:54 +0000 |
commit | 3ec78efb58bcde07d3cc2a9c0b58fac5a68f5ef3 (patch) | |
tree | 333ca4780758ea72ea57d33415d9534622ea14bc /src/plugins/baremetal | |
parent | 81a643ec99b1d20aab66a69b8c444bbbf696815a (diff) |
ProjectExplorer: Simplify ToolChainFactory::create() signature
Change-Id: I9d579898387609fa7374f43633711a978bb36d93
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/plugins/baremetal')
-rw-r--r-- | src/plugins/baremetal/iarewtoolchain.cpp | 10 | ||||
-rw-r--r-- | src/plugins/baremetal/iarewtoolchain.h | 3 | ||||
-rw-r--r-- | src/plugins/baremetal/keiltoolchain.cpp | 10 | ||||
-rw-r--r-- | src/plugins/baremetal/keiltoolchain.h | 3 | ||||
-rw-r--r-- | src/plugins/baremetal/sdcctoolchain.cpp | 10 | ||||
-rw-r--r-- | src/plugins/baremetal/sdcctoolchain.h | 3 |
6 files changed, 9 insertions, 30 deletions
diff --git a/src/plugins/baremetal/iarewtoolchain.cpp b/src/plugins/baremetal/iarewtoolchain.cpp index f40798cdb91..a094d47329a 100644 --- a/src/plugins/baremetal/iarewtoolchain.cpp +++ b/src/plugins/baremetal/iarewtoolchain.cpp @@ -226,12 +226,6 @@ IarToolChain::IarToolChain(Detection d) : ToolChain(Constants::IAREW_TOOLCHAIN_TYPEID, d) { } -IarToolChain::IarToolChain(Core::Id language, Detection d) : - IarToolChain(d) -{ - setLanguage(language); -} - QString IarToolChain::typeDisplayName() const { return Internal::IarToolChainFactory::tr("IAREW"); @@ -465,9 +459,9 @@ bool IarToolChainFactory::canCreate() return true; } -ToolChain *IarToolChainFactory::create(Core::Id language) +ToolChain *IarToolChainFactory::create() { - return new IarToolChain(language, ToolChain::ManualDetection); + return new IarToolChain(ToolChain::ManualDetection); } ToolChain *IarToolChainFactory::restore(const QVariantMap &data) diff --git a/src/plugins/baremetal/iarewtoolchain.h b/src/plugins/baremetal/iarewtoolchain.h index 902288e611b..751bd78b444 100644 --- a/src/plugins/baremetal/iarewtoolchain.h +++ b/src/plugins/baremetal/iarewtoolchain.h @@ -90,7 +90,6 @@ protected: private: explicit IarToolChain(Detection d); - explicit IarToolChain(Core::Id language, Detection d); ProjectExplorer::Abi m_targetAbi; Utils::FileName m_compilerCommand; @@ -112,7 +111,7 @@ public: const QList<ProjectExplorer::ToolChain *> &alreadyKnown) final; bool canCreate() final; - ProjectExplorer::ToolChain *create(Core::Id language) final; + ProjectExplorer::ToolChain *create() final; ProjectExplorer::ToolChain *restore(const QVariantMap &data) final; diff --git a/src/plugins/baremetal/keiltoolchain.cpp b/src/plugins/baremetal/keiltoolchain.cpp index c7d639e9738..984fb3341ea 100644 --- a/src/plugins/baremetal/keiltoolchain.cpp +++ b/src/plugins/baremetal/keiltoolchain.cpp @@ -243,12 +243,6 @@ KeilToolchain::KeilToolchain(Detection d) : ToolChain(Constants::KEIL_TOOLCHAIN_TYPEID, d) { } -KeilToolchain::KeilToolchain(Core::Id language, Detection d) : - KeilToolchain(d) -{ - setLanguage(language); -} - QString KeilToolchain::typeDisplayName() const { return Internal::KeilToolchainFactory::tr("KEIL"); @@ -469,9 +463,9 @@ bool KeilToolchainFactory::canCreate() return true; } -ToolChain *KeilToolchainFactory::create(Core::Id language) +ToolChain *KeilToolchainFactory::create() { - return new KeilToolchain(language, ToolChain::ManualDetection); + return new KeilToolchain(ToolChain::ManualDetection); } ToolChain *KeilToolchainFactory::restore(const QVariantMap &data) diff --git a/src/plugins/baremetal/keiltoolchain.h b/src/plugins/baremetal/keiltoolchain.h index e2c6d749925..475edc90268 100644 --- a/src/plugins/baremetal/keiltoolchain.h +++ b/src/plugins/baremetal/keiltoolchain.h @@ -90,7 +90,6 @@ protected: private: explicit KeilToolchain(Detection d); - explicit KeilToolchain(Core::Id language, Detection d); ProjectExplorer::Abi m_targetAbi; Utils::FileName m_compilerCommand; @@ -112,7 +111,7 @@ public: const QList<ProjectExplorer::ToolChain *> &alreadyKnown) final; bool canCreate() final; - ProjectExplorer::ToolChain *create(Core::Id language) final; + ProjectExplorer::ToolChain *create() final; ProjectExplorer::ToolChain *restore(const QVariantMap &data) final; diff --git a/src/plugins/baremetal/sdcctoolchain.cpp b/src/plugins/baremetal/sdcctoolchain.cpp index 79f245b5862..c3ca2f5d77e 100644 --- a/src/plugins/baremetal/sdcctoolchain.cpp +++ b/src/plugins/baremetal/sdcctoolchain.cpp @@ -220,12 +220,6 @@ SdccToolChain::SdccToolChain(Detection d) : ToolChain(Constants::SDCC_TOOLCHAIN_TYPEID, d) { } -SdccToolChain::SdccToolChain(Core::Id language, Detection d) : - SdccToolChain(d) -{ - setLanguage(language); -} - QString SdccToolChain::typeDisplayName() const { return Internal::SdccToolChainFactory::tr("SDCC"); @@ -446,9 +440,9 @@ bool SdccToolChainFactory::canCreate() return true; } -ToolChain *SdccToolChainFactory::create(Core::Id language) +ToolChain *SdccToolChainFactory::create() { - return new SdccToolChain(language, ToolChain::ManualDetection); + return new SdccToolChain(ToolChain::ManualDetection); } ToolChain *SdccToolChainFactory::restore(const QVariantMap &data) diff --git a/src/plugins/baremetal/sdcctoolchain.h b/src/plugins/baremetal/sdcctoolchain.h index e98675e7e3b..0675e49c0fb 100644 --- a/src/plugins/baremetal/sdcctoolchain.h +++ b/src/plugins/baremetal/sdcctoolchain.h @@ -90,7 +90,6 @@ protected: private: explicit SdccToolChain(Detection d); - explicit SdccToolChain(Core::Id language, Detection d); ProjectExplorer::Abi m_targetAbi; Utils::FileName m_compilerCommand; @@ -112,7 +111,7 @@ public: const QList<ProjectExplorer::ToolChain *> &alreadyKnown) final; bool canCreate() final; - ProjectExplorer::ToolChain *create(Core::Id language) final; + ProjectExplorer::ToolChain *create() final; ProjectExplorer::ToolChain *restore(const QVariantMap &data) final; |