ProjectExplorer: Use the fromMap(toMap()) pattern to clone devices

Change-Id: Ie6e73f5ef1019907dd311aac116d71f08b5a5202
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>

2 files changed, 1 insertions, 15 deletions

diff --git a/src/plugins/baremetal/baremetaldevice.cpp b/src/plugins/baremetal/baremetaldevice.cpp
index f262551f293..340ca1a2291 100644
--- a/src/plugins/baremetal/baremetaldevice.cpp
+++ b/src/plugins/baremetal/baremetaldevice.cpp
@@ -130,11 +130,6 @@ QVariantMap BareMetalDevice::toMap() const
     return map;
 }
 
-BareMetalDevice::IDevice::Ptr BareMetalDevice::clone() const
-{
-    return Ptr(new BareMetalDevice(*this));
-}
-
 DeviceProcessSignalOperation::Ptr BareMetalDevice::signalOperation() const
 {
     return DeviceProcessSignalOperation::Ptr();
@@ -160,13 +155,7 @@ DeviceProcess *BareMetalDevice::createProcess(QObject *parent) const
     return new GdbServerProviderProcess(sharedFromThis(), parent);
 }
 
-BareMetalDevice::BareMetalDevice(const BareMetalDevice &other)
-    : IDevice(other)
-{
-    setGdbServerProviderId(other.gdbServerProviderId());
-}
-
-// BareMetalDeviceFactory
+// Factory
 
 BareMetalDeviceFactory::BareMetalDeviceFactory()
     : IDeviceFactory(Constants::BareMetalOsType)
diff --git a/src/plugins/baremetal/baremetaldevice.h b/src/plugins/baremetal/baremetaldevice.h
index 1eac666192c..b4d1b3afceb 100644
--- a/src/plugins/baremetal/baremetaldevice.h
+++ b/src/plugins/baremetal/baremetaldevice.h
@@ -48,7 +48,6 @@ public:
     QString displayType() const final;
     ProjectExplorer::IDeviceWidget *createWidget() final;
     Utils::OsType osType() const final;
-    ProjectExplorer::IDevice::Ptr clone() const final;
 
     ProjectExplorer::DeviceProcessSignalOperation::Ptr signalOperation() const final;
 
@@ -65,10 +64,8 @@ public:
 
 private:
     explicit BareMetalDevice() = default;
-    explicit BareMetalDevice(const BareMetalDevice &other);
 
     void setChannelByServerProvider(GdbServerProvider *provider);
-    BareMetalDevice &operator=(const BareMetalDevice &);
     QString m_gdbServerProviderId;
 };