aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/bazaar
diff options
context:
space:
mode:
authorhjk <hjk@qt.io>2018-02-02 10:08:21 +0100
committerhjk <hjk@qt.io>2018-02-06 11:58:15 +0000
commit713b8636ea740502597b79b1a74382d1b3a70ab6 (patch)
treea1ece14ba7f98d1fa2ce01e4880c707dc5a74082 /src/plugins/bazaar
parente7792f8f50b21889f727884ab8b94cb87f38169e (diff)
Vcs/Text search: Remove a few addAutoReleaseObject uses
Using a QObject parent suffices here. Change-Id: I4dc5448511d55bf14fbd8f810e91336a49e94094 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Diffstat (limited to 'src/plugins/bazaar')
-rw-r--r--src/plugins/bazaar/bazaarplugin.cpp11
-rw-r--r--src/plugins/bazaar/optionspage.cpp4
-rw-r--r--src/plugins/bazaar/optionspage.h2
3 files changed, 8 insertions, 9 deletions
diff --git a/src/plugins/bazaar/bazaarplugin.cpp b/src/plugins/bazaar/bazaarplugin.cpp
index d3425a7b5c1..8d6b62e29c5 100644
--- a/src/plugins/bazaar/bazaarplugin.cpp
+++ b/src/plugins/bazaar/bazaarplugin.cpp
@@ -157,7 +157,7 @@ bool BazaarPlugin::initialize(const QStringList &arguments, QString *errorMessag
auto vcsCtrl = initializeVcs<BazaarControl>(context, m_client);
connect(m_client, &VcsBaseClient::changed, vcsCtrl, &BazaarControl::changed);
- addAutoReleasedObject(new OptionsPage(vcsCtrl));
+ new OptionsPage(vcsCtrl, this);
const auto describeFunc = [this](const QString &source, const QString &id) {
m_client->view(source, id);
@@ -165,14 +165,13 @@ bool BazaarPlugin::initialize(const QStringList &arguments, QString *errorMessag
const int editorCount = sizeof(editorParameters) / sizeof(VcsBaseEditorParameters);
const auto widgetCreator = []() { return new BazaarEditorWidget; };
for (int i = 0; i < editorCount; i++)
- addAutoReleasedObject(new VcsEditorFactory(editorParameters + i, widgetCreator, describeFunc));
+ new VcsEditorFactory(editorParameters + i, widgetCreator, describeFunc, this);
- addAutoReleasedObject(new VcsSubmitEditorFactory(&submitEditorParameters,
- []() { return new CommitEditor(&submitEditorParameters); }));
+ (void) new VcsSubmitEditorFactory(&submitEditorParameters,
+ []() { return new CommitEditor(&submitEditorParameters); }, this);
const QString prefix = QLatin1String("bzr");
- m_commandLocator = new CommandLocator("Bazaar", prefix, prefix);
- addAutoReleasedObject(m_commandLocator);
+ m_commandLocator = new CommandLocator("Bazaar", prefix, prefix, this);
createMenu(context);
diff --git a/src/plugins/bazaar/optionspage.cpp b/src/plugins/bazaar/optionspage.cpp
index 74078b88247..877a7e6dc40 100644
--- a/src/plugins/bazaar/optionspage.cpp
+++ b/src/plugins/bazaar/optionspage.cpp
@@ -65,8 +65,8 @@ void OptionsPageWidget::setSettings(const VcsBaseClientSettings &s)
m_ui.timeout->setValue(s.intValue(BazaarSettings::timeoutKey));
}
-OptionsPage::OptionsPage(Core::IVersionControl *control) :
- VcsClientOptionsPage(control, BazaarPlugin::instance()->client())
+OptionsPage::OptionsPage(Core::IVersionControl *control, QObject *parent) :
+ VcsClientOptionsPage(control, BazaarPlugin::instance()->client(), parent)
{
setId(VcsBase::Constants::VCS_ID_BAZAAR);
setDisplayName(tr("Bazaar"));
diff --git a/src/plugins/bazaar/optionspage.h b/src/plugins/bazaar/optionspage.h
index 246a277eb3f..6d981e8df2f 100644
--- a/src/plugins/bazaar/optionspage.h
+++ b/src/plugins/bazaar/optionspage.h
@@ -54,7 +54,7 @@ class OptionsPage : public VcsBase::VcsClientOptionsPage
Q_OBJECT
public:
- OptionsPage(Core::IVersionControl *control);
+ OptionsPage(Core::IVersionControl *control, QObject *parent);
};
} // namespace Internal