aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/clangcodemodel/clangdfollowsymbol.h
diff options
context:
space:
mode:
authorChristian Kandeler <christian.kandeler@qt.io>2022-07-18 18:08:01 +0200
committerEike Ziller <eike.ziller@qt.io>2022-07-19 07:44:18 +0000
commit5c341854e08b2dae02aa1333c76395a964581bd5 (patch)
treeb9f34dc5f86c3fc19b21fb8eae579a2d3788a0b9 /src/plugins/clangcodemodel/clangdfollowsymbol.h
parentb2407dbde5840b69aa076fd72d169dd90438f71e (diff)
ClangCodeModel: Fix callback handling when following symbolsv8.0.0
Make sure emitDone() is atomic with running the callback, so in case the latter starts an event loop of its own, we won't be overtaken by incoming signals, deleting the object from under us. Task-number: QTCREATORBUG-27910 Change-Id: I586d7609974662bf391b12041f416aaa2a973ecb Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Diffstat (limited to 'src/plugins/clangcodemodel/clangdfollowsymbol.h')
-rw-r--r--src/plugins/clangcodemodel/clangdfollowsymbol.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/clangcodemodel/clangdfollowsymbol.h b/src/plugins/clangcodemodel/clangdfollowsymbol.h
index fffe2c42b9..09094bbed5 100644
--- a/src/plugins/clangcodemodel/clangdfollowsymbol.h
+++ b/src/plugins/clangcodemodel/clangdfollowsymbol.h
@@ -55,7 +55,7 @@ signals:
void done();
private:
- void emitDone();
+ void emitDone(const Utils::Link &link = {});
class VirtualFunctionAssistProcessor;
class VirtualFunctionAssistProvider;