diff options
| author | Eike Ziller <eike.ziller@qt.io> | 2019-01-29 11:43:43 +0100 |
|---|---|---|
| committer | Eike Ziller <eike.ziller@qt.io> | 2019-02-01 11:00:55 +0000 |
| commit | 32429e11c90ec035d10f23aa079a18869cf546a0 (patch) | |
| tree | d49747aadf0f6854ad53b916a89b791c15751076 /src/plugins/clangcodemodel | |
| parent | 4e8c2c4b13f7518b4c3d27c12daaa42d0442f606 (diff) | |
Help: Avoid double lookup for help tooltips
Save the HelpItem directly in the tooltip instead of the help ID which
would need to be looked up again.
Change-Id: I107e82e89d9ea26cad9d6532ad4c687d1ac8f1ec
Reviewed-by: David Schulz <david.schulz@qt.io>
Diffstat (limited to 'src/plugins/clangcodemodel')
| -rw-r--r-- | src/plugins/clangcodemodel/clanghoverhandler.cpp | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/src/plugins/clangcodemodel/clanghoverhandler.cpp b/src/plugins/clangcodemodel/clanghoverhandler.cpp index fb8b751d87..446b436325 100644 --- a/src/plugins/clangcodemodel/clanghoverhandler.cpp +++ b/src/plugins/clangcodemodel/clanghoverhandler.cpp @@ -75,7 +75,7 @@ static bool editorDocumentProcessorHasDiagnosticAt(TextEditorWidget *editorWidge static void processWithEditorDocumentProcessor(TextEditorWidget *editorWidget, const QPoint &point, int position, - const QString &helpId) + const Core::HelpItem &helpItem) { if (CppTools::BaseEditorDocumentProcessor *processor = editorDocumentProcessor(editorWidget)) { int line, column; @@ -84,7 +84,7 @@ static void processWithEditorDocumentProcessor(TextEditorWidget *editorWidget, layout->setContentsMargins(0, 0, 0, 0); layout->setSpacing(2); processor->addDiagnosticToolTipToLayout(line, column, layout); - Utils::ToolTip::show(point, layout, editorWidget, helpId); + Utils::ToolTip::show(point, layout, editorWidget, qVariantFromValue(helpItem)); } } } @@ -283,9 +283,10 @@ void ClangHoverHandler::operateTooltip(TextEditor::TextEditorWidget *editorWidge const QPoint &point) { if (priority() == Priority_Diagnostic) { - const Core::HelpItem helpItem = lastHelpItemIdentified(); - const QString helpId = helpItem.isValid() ? helpItem.helpId() : QString(); - processWithEditorDocumentProcessor(editorWidget, point, m_cursorPosition, helpId); + processWithEditorDocumentProcessor(editorWidget, + point, + m_cursorPosition, + lastHelpItemIdentified()); return; } |