diff options
author | hjk <hjk@qt.io> | 2018-02-02 10:08:21 +0100 |
---|---|---|
committer | hjk <hjk@qt.io> | 2018-02-06 11:58:15 +0000 |
commit | 713b8636ea740502597b79b1a74382d1b3a70ab6 (patch) | |
tree | a1ece14ba7f98d1fa2ce01e4880c707dc5a74082 /src/plugins/clearcase | |
parent | e7792f8f50b21889f727884ab8b94cb87f38169e (diff) |
Vcs/Text search: Remove a few addAutoReleaseObject uses
Using a QObject parent suffices here.
Change-Id: I4dc5448511d55bf14fbd8f810e91336a49e94094
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Diffstat (limited to 'src/plugins/clearcase')
-rw-r--r-- | src/plugins/clearcase/clearcaseplugin.cpp | 11 | ||||
-rw-r--r-- | src/plugins/clearcase/settingspage.cpp | 3 | ||||
-rw-r--r-- | src/plugins/clearcase/settingspage.h | 2 |
3 files changed, 8 insertions, 8 deletions
diff --git a/src/plugins/clearcase/clearcaseplugin.cpp b/src/plugins/clearcase/clearcaseplugin.cpp index 266a56e18e3..bcc1bd40f13 100644 --- a/src/plugins/clearcase/clearcaseplugin.cpp +++ b/src/plugins/clearcase/clearcaseplugin.cpp @@ -423,10 +423,10 @@ bool ClearCasePlugin::initialize(const QStringList & /*arguments */, QString *er connect(SessionManager::instance(), &SessionManager::startupProjectChanged, this, &ClearCasePlugin::projectChanged); - addAutoReleasedObject(new SettingsPage); + new SettingsPage(this); - addAutoReleasedObject(new VcsSubmitEditorFactory(&submitParameters, - []() { return new ClearCaseSubmitEditor(&submitParameters); })); + new VcsSubmitEditorFactory(&submitParameters, + []() { return new ClearCaseSubmitEditor(&submitParameters); }, this); // any editor responds to describe (when clicking a version) const auto describeFunc = [this](const QString &source, const QString &changeNr) { @@ -435,13 +435,12 @@ bool ClearCasePlugin::initialize(const QStringList & /*arguments */, QString *er const int editorCount = sizeof(editorParameters)/sizeof(VcsBaseEditorParameters); const auto widgetCreator = []() { return new ClearCaseEditorWidget; }; for (int i = 0; i < editorCount; i++) - addAutoReleasedObject(new VcsEditorFactory(editorParameters + i, widgetCreator, describeFunc)); + new VcsEditorFactory(editorParameters + i, widgetCreator, describeFunc, this); const QString description = QLatin1String("ClearCase"); const QString prefix = QLatin1String("cc"); // register cc prefix in Locator - m_commandLocator = new CommandLocator("cc", description, prefix); - addAutoReleasedObject(m_commandLocator); + m_commandLocator = new CommandLocator("cc", description, prefix, this); //register actions ActionContainer *toolsContainer = ActionManager::actionContainer(M_TOOLS); diff --git a/src/plugins/clearcase/settingspage.cpp b/src/plugins/clearcase/settingspage.cpp index 1f679a2a419..8414e0eaf00 100644 --- a/src/plugins/clearcase/settingspage.cpp +++ b/src/plugins/clearcase/settingspage.cpp @@ -104,7 +104,8 @@ void SettingsPageWidget::setSettings(const ClearCaseSettings &s) m_ui.indexOnlyVOBsEdit->setText(s.indexOnlyVOBs); } -SettingsPage::SettingsPage() +SettingsPage::SettingsPage(QObject *parent) + : VcsBaseOptionsPage(parent) { setId(ClearCase::Constants::VCS_ID_CLEARCASE); setDisplayName(tr("ClearCase")); diff --git a/src/plugins/clearcase/settingspage.h b/src/plugins/clearcase/settingspage.h index 257cc58faa5..cb8a96b81a9 100644 --- a/src/plugins/clearcase/settingspage.h +++ b/src/plugins/clearcase/settingspage.h @@ -57,7 +57,7 @@ class SettingsPage : public VcsBase::VcsBaseOptionsPage Q_OBJECT public: - SettingsPage(); + explicit SettingsPage(QObject *parent); QWidget *widget() override; void apply() override; |