diff options
| author | Aaron Barany <akb825@gmail.com> | 2019-01-23 22:41:58 -0800 |
|---|---|---|
| committer | Aaron Barany <akb825@gmail.com> | 2019-01-25 18:48:18 +0000 |
| commit | d2e420bfe725d79278a2c22415e5c4682bab77b2 (patch) | |
| tree | e34c177baa1503240ef7ab59b76119d43f9e2cb1 /src/plugins/cmakeprojectmanager/cmakebuildstep.h | |
| parent | 63ae7eeb1b9b09cc9a879383b17ff6ba1881ddd4 (diff) | |
CMake: Don't change targets when parsing fails
When first loading a CMake project, if parsing fails all targets get reset
to the "all" target. Most commonly users will notice this when the "clean"
target gets reset to "all", and can often go unnoticed for a while. This
can become especially annoying when custom target configurations are used.
With this change the previous targets will be preserved upon failure.
Fixes: QTCREATORBUG-21617
Change-Id: I52a3a2c472c7b8d98bc016b1e55a202147fc091c
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Diffstat (limited to 'src/plugins/cmakeprojectmanager/cmakebuildstep.h')
| -rw-r--r-- | src/plugins/cmakeprojectmanager/cmakebuildstep.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/cmakeprojectmanager/cmakebuildstep.h b/src/plugins/cmakeprojectmanager/cmakebuildstep.h index cfae9c9aab..91dab9b455 100644 --- a/src/plugins/cmakeprojectmanager/cmakebuildstep.h +++ b/src/plugins/cmakeprojectmanager/cmakebuildstep.h @@ -101,7 +101,7 @@ private: void runImpl(QFutureInterface<bool> &fi); void handleProjectWasParsed(QFutureInterface<bool> &fi, bool success); - void handleBuildTargetChanges(); + void handleBuildTargetChanges(bool success); CMakeRunConfiguration *targetsActiveRunConfiguration() const; QMetaObject::Connection m_runTrigger; |