diff options
author | Eike Ziller <eike.ziller@qt.io> | 2017-05-29 12:50:20 +0200 |
---|---|---|
committer | Eike Ziller <eike.ziller@qt.io> | 2017-06-13 12:42:13 +0000 |
commit | 247639d9c301cfd6bed6096260d047c2b82ea129 (patch) | |
tree | d360d5a887e837d663e6badb8d04748b5f34707b /src/plugins/coreplugin/locator/externaltoolsfilter.cpp | |
parent | 19a47fed29969484313d76c125915dedf19cb6e6 (diff) |
Remove 1-1 dependency between locator and locator input widget
Add possibility for filters to set a new search text when accepting
an entry.
Move placeholder text update from locator manager to widget.
Propagate filter update through signal-slot connection instead of directly.
LocatorManager::show is the only place left that directly references the locator widget.
Change-Id: Id61354d9f166c2af8c9d5528ad8998c7c6b8e1ab
Reviewed-by: David Schulz <david.schulz@qt.io>
Diffstat (limited to 'src/plugins/coreplugin/locator/externaltoolsfilter.cpp')
-rw-r--r-- | src/plugins/coreplugin/locator/externaltoolsfilter.cpp | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/plugins/coreplugin/locator/externaltoolsfilter.cpp b/src/plugins/coreplugin/locator/externaltoolsfilter.cpp index 7307473168b..72b75303f38 100644 --- a/src/plugins/coreplugin/locator/externaltoolsfilter.cpp +++ b/src/plugins/coreplugin/locator/externaltoolsfilter.cpp @@ -47,8 +47,12 @@ QList<LocatorFilterEntry> ExternalToolsFilter::matchesFor(QFutureInterface<Locat return m_results; } -void ExternalToolsFilter::accept(LocatorFilterEntry selection) const +void ExternalToolsFilter::accept(LocatorFilterEntry selection, + QString *newText, int *selectionStart, int *selectionLength) const { + Q_UNUSED(newText) + Q_UNUSED(selectionStart) + Q_UNUSED(selectionLength) auto tool = selection.internalData.value<ExternalTool *>(); QTC_ASSERT(tool, return); |