CorePlugin: Compile with QT_NO_CAST_FROM_ASCII.

- Wrap literals in QLatin1String()/QLatin1Char().
- Extract some string constants avoiding repeated
  QString construction.
- Fix repeated invocation of Container.end() in loops.

Change-Id: If737735507aaf82e53063adda53f54c46418f42f
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>

1 files changed, 6 insertions, 6 deletions

diff --git a/src/plugins/coreplugin/rightpane.cpp b/src/plugins/coreplugin/rightpane.cpp
index 4cc6307c76..5c026e0465 100644
--- a/src/plugins/coreplugin/rightpane.cpp
+++ b/src/plugins/coreplugin/rightpane.cpp
@@ -173,20 +173,20 @@ void RightPaneWidget::resizeEvent(QResizeEvent *re)
 
 void RightPaneWidget::saveSettings(QSettings *settings)
 {
-    settings->setValue("RightPane/Visible", isShown());
-    settings->setValue("RightPane/Width", m_width);
+    settings->setValue(QLatin1String("RightPane/Visible"), isShown());
+    settings->setValue(QLatin1String("RightPane/Width"), m_width);
 }
 
 void RightPaneWidget::readSettings(QSettings *settings)
 {
-    if (settings->contains("RightPane/Visible")) {
-        setShown(settings->value("RightPane/Visible").toBool());
+    if (settings->contains(QLatin1String("RightPane/Visible"))) {
+        setShown(settings->value(QLatin1String("RightPane/Visible")).toBool());
     } else {
         setShown(false); //TODO set to false
     }
 
-    if (settings->contains("RightPane/Width")) {
-        m_width = settings->value("RightPane/Width").toInt();
+    if (settings->contains(QLatin1String("RightPane/Width"))) {
+        m_width = settings->value(QLatin1String("RightPane/Width")).toInt();
         if (!m_width)
             m_width = 500;
     } else {