diff options
| author | Nikolai Kosjar <nikolai.kosjar@digia.com> | 2013-03-18 14:58:46 +0100 |
|---|---|---|
| committer | Nikolai Kosjar <nikolai.kosjar@digia.com> | 2013-03-19 14:12:11 +0100 |
| commit | 947207c8020f6de25077481538e2855dc643c55e (patch) | |
| tree | 0f5a11d913545b3e0b032bc44a5da28299516438 /src/plugins/cpptools/cppcompletionassist.h | |
| parent | 7f61d11311187b45e1bff859cd097eab59342cc7 (diff) | |
C++: Fix dangling IDocument* in CppCompletionAssistProcessor
Steps to reproduce the crash:
1. Open some long file, e.g. botan.cpp
2. Trigger completion and close editor immediately
The IDocument pointer was only used to reference the file name. Instead
of passing an IDocument* to the IAssistInterface, pass the file name.
Change-Id: Iafce9b818806a77968a10541114bc9b7c8665f11
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
Reviewed-by: David Schulz <david.schulz@digia.com>
Diffstat (limited to 'src/plugins/cpptools/cppcompletionassist.h')
| -rw-r--r-- | src/plugins/cpptools/cppcompletionassist.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/plugins/cpptools/cppcompletionassist.h b/src/plugins/cpptools/cppcompletionassist.h index e574fb413a..23d7b387bb 100644 --- a/src/plugins/cpptools/cppcompletionassist.h +++ b/src/plugins/cpptools/cppcompletionassist.h @@ -167,12 +167,12 @@ class CppCompletionAssistInterface : public TextEditor::DefaultAssistInterface public: CppCompletionAssistInterface(QTextDocument *textDocument, int position, - Core::IDocument *document, + const QString &fileName, TextEditor::AssistReason reason, const CPlusPlus::Snapshot &snapshot, const QStringList &includePaths, const QStringList &frameworkPaths) - : TextEditor::DefaultAssistInterface(textDocument, position, document, reason) + : TextEditor::DefaultAssistInterface(textDocument, position, fileName, reason) , m_snapshot(snapshot) , m_includePaths(includePaths) , m_frameworkPaths(frameworkPaths) |