diff options
| author | Denis Mingulov <denis@mingulov.com> | 2012-02-16 09:55:47 +0200 |
|---|---|---|
| committer | hjk <qthjk@ovi.com> | 2012-02-16 10:27:04 +0100 |
| commit | 87b1dc25a1c67815f88041fbe57794e4099655e2 (patch) | |
| tree | 4c42b5bf8c962d14b0fcfd9802c9ab354d0a9b52 /src/plugins/debugger/memoryview.cpp | |
| parent | d766c2e77342ea3a3f6cb8f999d66569bf299d4e (diff) | |
Debugger: use QString::fromLatin1 instead of QString::fromAscii
By source - latin1 is really expected as there is no any check
or usage of QTextCodec::setCodecForCStrings() currently.
QString::fromAscii() might break 'Latin1' input in some cases.
A quote from documentation about QString::fromAscii():
"Note that, despite the name, this function actually uses the
codec defined by QTextCodec::setCodecForCStrings() to convert str
to Unicode. Depending on the codec, it may not accept valid
US-ASCII (ANSI X3.4-1986) input. If no codec has been set, this
function does the same as fromLatin1()."
Change-Id: I49cf047ca674d2ec621b517c635d1927bb2e796f
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: hjk <qthjk@ovi.com>
Diffstat (limited to 'src/plugins/debugger/memoryview.cpp')
| -rw-r--r-- | src/plugins/debugger/memoryview.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/debugger/memoryview.cpp b/src/plugins/debugger/memoryview.cpp index 2857bac1b4..0eea953456 100644 --- a/src/plugins/debugger/memoryview.cpp +++ b/src/plugins/debugger/memoryview.cpp @@ -184,7 +184,7 @@ QList<MemoryMarkup> RegisterMemoryView::registerMarkup(quint64 a, const QString void RegisterMemoryView::init(RegisterHandler *h, int registerIndex) { m_registerIndex = registerIndex; - m_registerName = QString::fromAscii(h->registerAt(registerIndex).name); + m_registerName = QString::fromLatin1(h->registerAt(registerIndex).name); // Known issue: CDB might reset the model by changing the special // registers it reports. connect(h, SIGNAL(modelReset()), this, SLOT(close())); |