aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/debugger/qml/qmlengine.cpp
diff options
context:
space:
mode:
authorUlf Hermann <ulf.hermann@qt.io>2018-07-25 13:36:52 +0000
committerThe Qt Project <gerrit-noreply@qt-project.org>2018-07-25 13:36:52 +0000
commit59175ac42331d78d8b7cd15f208aaee5506ace68 (patch)
tree61dbef295ae739351f592603a6da803ae2a7fcc2 /src/plugins/debugger/qml/qmlengine.cpp
parent859d847769f12592a129c562b1c44c8bfd729d1a (diff)
parent5b8989d01772099815d1b1acfd44bfe708c5bfff (diff)
Merge "Merge remote-tracking branch 'origin/4.7'"
Diffstat (limited to 'src/plugins/debugger/qml/qmlengine.cpp')
-rw-r--r--src/plugins/debugger/qml/qmlengine.cpp17
1 files changed, 7 insertions, 10 deletions
diff --git a/src/plugins/debugger/qml/qmlengine.cpp b/src/plugins/debugger/qml/qmlengine.cpp
index 9c389813e4..62034f245f 100644
--- a/src/plugins/debugger/qml/qmlengine.cpp
+++ b/src/plugins/debugger/qml/qmlengine.cpp
@@ -758,22 +758,19 @@ void QmlEngine::changeBreakpoint(Breakpoint bp)
BreakpointResponse br = bp.response();
if (params.type == BreakpointAtJavaScriptThrow) {
d->setExceptionBreak(AllExceptions, params.enabled);
- br.enabled = params.enabled;
- bp.setResponse(br);
} else if (params.type == BreakpointOnQmlSignalEmit) {
d->setBreakpoint(EVENT, params.functionName, params.enabled);
- br.enabled = params.enabled;
- bp.setResponse(br);
} else if (d->canChangeBreakpoint()) {
d->changeBreakpoint(d->breakpoints.value(bp.id()), params.enabled);
} else {
- //V8 supports only minimalistic changes in breakpoint
- //Remove the breakpoint and add again
- bp.notifyBreakpointChangeOk();
- bp.removeBreakpoint();
- BreakHandler *handler = d->engine->breakHandler();
- handler->appendBreakpoint(params);
+ d->clearBreakpoint(d->breakpoints.take(bp.id()));
+ d->setBreakpoint(SCRIPTREGEXP, params.fileName,
+ params.enabled, params.lineNumber, 0,
+ params.condition, params.ignoreCount);
+ d->breakpointsSync.insert(d->sequence, bp.id());
}
+ br.enabled = params.enabled;
+ bp.setResponse(br);
if (bp.state() == BreakpointChangeProceeding)
bp.notifyBreakpointChangeOk();