aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/git
diff options
context:
space:
mode:
authorOrgad Shaneh <orgad.shaneh@audiocodes.com>2018-11-09 09:59:40 +0200
committerOrgad Shaneh <orgads@gmail.com>2018-11-12 18:35:44 +0000
commit15b176e30c0a3a6e6effe0043a5133241caa9d2f (patch)
tree9e7d7c3ef6527dd7e988b455b13918b793d3e314 /src/plugins/git
parent7d56d89f255335511fb22ec43e047a0d2bb38a91 (diff)
VCS: Improve dialog on submit prompt
The dialog appears when closing the commit dialog without committing, or when "prompt to submit" setting is enabled. Fixes: QTCREATORBUG-18799 Change-Id: I8eb20becbcee7281b9f673a35ec698c6f8e04a40 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Robert Loehning <robert.loehning@qt.io> Reviewed-by: André Hartmann <aha_1980@gmx.de>
Diffstat (limited to 'src/plugins/git')
-rw-r--r--src/plugins/git/gitplugin.cpp6
1 files changed, 1 insertions, 5 deletions
diff --git a/src/plugins/git/gitplugin.cpp b/src/plugins/git/gitplugin.cpp
index f9dfa4a31c..8d2c54df9e 100644
--- a/src/plugins/git/gitplugin.cpp
+++ b/src/plugins/git/gitplugin.cpp
@@ -1034,12 +1034,8 @@ bool GitPlugin::submitEditorAboutToClose()
return true;
// Prompt user. Force a prompt unless submit was actually invoked (that
// is, the editor was closed or shutdown).
- bool promptData = false;
const VcsBaseSubmitEditor::PromptSubmitResult answer
- = editor->promptSubmit(tr("Closing Git Editor"),
- tr("Do you want to commit the change?"),
- tr("Git will not accept this commit. Do you want to continue to edit it?"),
- &promptData, !m_submitActionTriggered, false);
+ = editor->promptSubmit(this, nullptr, !m_submitActionTriggered, false);
m_submitActionTriggered = false;
switch (answer) {
case VcsBaseSubmitEditor::SubmitCanceled: