diff options
| author | Eike Ziller <eike.ziller@qt.io> | 2019-02-01 12:11:57 +0100 |
|---|---|---|
| committer | Eike Ziller <eike.ziller@qt.io> | 2019-02-04 09:20:55 +0000 |
| commit | 92ddaea43edc761aad32648de61187186a665711 (patch) | |
| tree | 6c6fe2eda17a7022f3a51dceacd7dfdb27f40b5f /src/plugins/help/helpplugin.cpp | |
| parent | d07e5b2a466484511aec42dc1b7e6a52afb99a55 (diff) | |
Help: Make a difference between "empty" and "valid"
Context help should take the HelpItem from the tool tip if it was set,
even if it isn't valid.
Similarly, if the help item was set on the text editor, it should not
ask the hover handlers (again), even if that is invalid
Change-Id: I481f8ad73c3cf8fdbb90f737ab36b4e380467026
Reviewed-by: David Schulz <david.schulz@qt.io>
Diffstat (limited to 'src/plugins/help/helpplugin.cpp')
| -rw-r--r-- | src/plugins/help/helpplugin.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/help/helpplugin.cpp b/src/plugins/help/helpplugin.cpp index cfaec938e7..df16af3101 100644 --- a/src/plugins/help/helpplugin.cpp +++ b/src/plugins/help/helpplugin.cpp @@ -652,7 +652,7 @@ void HelpPluginPrivate::requestContextHelp() ? tipHelpValue.value<HelpItem>() : HelpItem(tipHelpValue.toString()); IContext *context = ICore::currentContextObject(); - if (!tipHelp.isValid() && context) + if (tipHelp.isEmpty() && context) context->contextHelp([this](const HelpItem &item) { showContextHelp(item); }); else showContextHelp(tipHelp); |