Avoid build progress' error widget flickering, and popping up as toplevel on Mac

When a build was started after a build had errors, the error widget
would be made visible before it had a parent, leading to it being shown
as a top level for a split second.
So, clear the tasks before creating the new error widget, and assume
that we start without errors in the error widget.

1 files changed, 1 insertions, 2 deletions

diff --git a/src/plugins/projectexplorer/buildprogress.cpp b/src/plugins/projectexplorer/buildprogress.cpp
index 42b29bef57..6e954d67d8 100644
--- a/src/plugins/projectexplorer/buildprogress.cpp
+++ b/src/plugins/projectexplorer/buildprogress.cpp
@@ -79,7 +79,6 @@ BuildProgress::BuildProgress(TaskWindow *taskWindow)
     hide();
 
     connect(m_taskWindow, SIGNAL(tasksChanged()), this, SLOT(updateState()));
-    updateState();
 }
 
 void BuildProgress::updateState()
@@ -98,9 +97,9 @@ void BuildProgress::updateState()
     m_warningLabel->setText(QString("%1").arg(warnings));
 
     // Hide warnings and errors unless you need them
-    setVisible(haveWarnings | haveErrors);
     m_warningIcon->setVisible(haveWarnings);
     m_warningLabel->setVisible(haveWarnings);
     m_errorIcon->setVisible(haveErrors);
     m_errorLabel->setVisible(haveErrors);
+    setVisible(haveWarnings || haveErrors);
 }