ProjectExplorer: Use BuildStep member to decide on initial expansion

Previously, the build step implementation had the same power as it
decided on the widget to use, and the widget had such a member.

Change-Id: Id9c783e29610b68cfbbe2c9aa91da831d41c3286
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>

1 files changed, 5 insertions, 3 deletions

diff --git a/src/plugins/projectexplorer/buildstep.h b/src/plugins/projectexplorer/buildstep.h
index 6e82656566..4a368a5eeb 100644
--- a/src/plugins/projectexplorer/buildstep.h
+++ b/src/plugins/projectexplorer/buildstep.h
@@ -84,6 +84,9 @@ public:
 
     bool isActive() const override;
 
+    bool widgetExpandedByDefault() const;
+    void setWidgetExpandedByDefault(bool widgetExpandedByDefault);
+
 signals:
     /// Adds a \p task to the Issues pane.
     /// Do note that for linking compile output with tasks, you should first emit the task
@@ -99,6 +102,7 @@ signals:
 
 private:
     bool m_enabled = true;
+    bool m_widgetExpandedByDefault = true;
 };
 
 class PROJECTEXPLORER_EXPORT BuildStepInfo
@@ -171,12 +175,11 @@ class PROJECTEXPLORER_EXPORT BuildStepConfigWidget : public QWidget
 {
     Q_OBJECT
 public:
-    BuildStepConfigWidget(BuildStep *step, bool showWidget = true);
+    explicit BuildStepConfigWidget(BuildStep *step);
 
     QString summaryText() const;
     QString displayName() const;
     BuildStep *step() const { return m_step; }
-    bool showWidget() const { return m_showWidget; }
 
     void setDisplayName(const QString &displayName);
     void setSummaryText(const QString &summaryText);
@@ -186,7 +189,6 @@ signals:
 
 private:
     BuildStep *m_step = nullptr;
-    const bool m_showWidget = true;
     QString m_displayName;
     QString m_summaryText;
 };