Always pass Core::Id by value.

Currently we pass in some places by value, elsewhere by const ref and
for some weird reason also by const value in a lot of places. The latter
is particularly annoying, as it is also used in interfaces and therefore
forces all implementors to do the same, since leaving the "const" off is
causing compiler warnings with MSVC.

Change-Id: I65b87dc3cce0986b8a55ff6119cb752361027803
Reviewed-by: hjk <hjk121@nokiamail.com>

1 files changed, 4 insertions, 4 deletions

diff --git a/src/plugins/projectexplorer/buildstep.h b/src/plugins/projectexplorer/buildstep.h
index ca9b536b50..366e4528dc 100644
--- a/src/plugins/projectexplorer/buildstep.h
+++ b/src/plugins/projectexplorer/buildstep.h
@@ -51,7 +51,7 @@ class PROJECTEXPLORER_EXPORT BuildStep : public ProjectConfiguration
     Q_OBJECT
 
 protected:
-    BuildStep(BuildStepList *bsl, const Core::Id id);
+    BuildStep(BuildStepList *bsl, Core::Id id);
     BuildStep(BuildStepList *bsl, BuildStep *bs);
 
 public:
@@ -107,10 +107,10 @@ public:
     // used to show the list of possible additons to a target, returns a list of types
     virtual QList<Core::Id> availableCreationIds(BuildStepList *parent) const = 0;
     // used to translate the types to names to display to the user
-    virtual QString displayNameForId(const Core::Id id) const = 0;
+    virtual QString displayNameForId(Core::Id id) const = 0;
 
-    virtual bool canCreate(BuildStepList *parent, const Core::Id id) const = 0;
-    virtual BuildStep *create(BuildStepList *parent, const Core::Id id) = 0;
+    virtual bool canCreate(BuildStepList *parent, Core::Id id) const = 0;
+    virtual BuildStep *create(BuildStepList *parent, Core::Id id) = 0;
     // used to recreate the runConfigurations when restoring settings
     virtual bool canRestore(BuildStepList *parent, const QVariantMap &map) const = 0;
     virtual BuildStep *restore(BuildStepList *parent, const QVariantMap &map) = 0;