ProjectExplorer: Remember build step expansion state

... when switching targets.
If a user expands a build step and then switches the target, it's
reasonable for them to assume that the step is still expanded when
switching back.
Ideally, we would also do this for aspects (if only for consistency),
but unlike for build steps there's no central code location, so let's
leave it at this for now.

Fixes: QTCREATORBUG-21343
Change-Id: Ic142ab5d676bf7d3b6aeabb6f7a26be7bd18f22c
Reviewed-by: hjk <hjk@qt.io>

1 files changed, 6 insertions, 0 deletions

diff --git a/src/plugins/projectexplorer/buildstep.h b/src/plugins/projectexplorer/buildstep.h
index 4d2cf7bea2..0abf7d5b78 100644
--- a/src/plugins/projectexplorer/buildstep.h
+++ b/src/plugins/projectexplorer/buildstep.h
@@ -28,6 +28,7 @@
 #include "projectconfiguration.h"
 #include "projectexplorer_export.h"
 
+#include <utils/optional.h>
 #include <utils/qtcassert.h>
 
 #include <QFutureInterface>
@@ -88,6 +89,10 @@ public:
     bool widgetExpandedByDefault() const;
     void setWidgetExpandedByDefault(bool widgetExpandedByDefault);
 
+    bool hasUserExpansionState() const { return m_wasExpanded.has_value(); }
+    bool wasUserExpanded() const { return m_wasExpanded.value_or(false); }
+    void setUserExpanded(bool expanded) { m_wasExpanded = expanded; }
+
     bool isImmutable() const { return m_immutable; }
     void setImmutable(bool immutable) { m_immutable = immutable; }
 
@@ -123,6 +128,7 @@ private:
     bool m_immutable = false;
     bool m_widgetExpandedByDefault = true;
     bool m_runInGuiThread = true;
+    Utils::optional<bool> m_wasExpanded;
 };
 
 class PROJECTEXPLORER_EXPORT BuildStepInfo