diff options
| author | Tobias Hunger <tobias.hunger@theqtcompany.com> | 2016-02-02 18:26:51 +0100 |
|---|---|---|
| committer | Tobias Hunger <tobias.hunger@theqtcompany.com> | 2016-02-03 08:29:08 +0000 |
| commit | f4296d7504e87d291232bc13caa99a439d2393ab (patch) | |
| tree | 66892ae3ded5333a7036401031effaf228921d3a /src/plugins/projectexplorer/buildstep.h | |
| parent | 6a3e687d140cad3dec006b2d5fa8982d4b10f31c (diff) | |
ProjectExplorer: Modernize
* Use override where appropriate
* Use pragma once
* Make more constructors explicit
Change-Id: I2865fe10f288e3de570826058e43b70a0cb4ee37
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Diffstat (limited to 'src/plugins/projectexplorer/buildstep.h')
| -rw-r--r-- | src/plugins/projectexplorer/buildstep.h | 22 |
1 files changed, 5 insertions, 17 deletions
diff --git a/src/plugins/projectexplorer/buildstep.h b/src/plugins/projectexplorer/buildstep.h index f3d257018a..727c4ee3ba 100644 --- a/src/plugins/projectexplorer/buildstep.h +++ b/src/plugins/projectexplorer/buildstep.h @@ -23,8 +23,7 @@ ** ****************************************************************************/ -#ifndef BUILDSTEP_H -#define BUILDSTEP_H +#pragma once #include "projectconfiguration.h" #include "projectexplorer_export.h" @@ -94,8 +93,7 @@ private: bool m_enabled; }; -class PROJECTEXPLORER_EXPORT IBuildStepFactory : - public QObject +class PROJECTEXPLORER_EXPORT IBuildStepFactory : public QObject { Q_OBJECT @@ -116,14 +114,10 @@ public: virtual BuildStep *clone(BuildStepList *parent, BuildStep *product) = 0; }; -class PROJECTEXPLORER_EXPORT BuildStepConfigWidget - : public QWidget +class PROJECTEXPLORER_EXPORT BuildStepConfigWidget : public QWidget { Q_OBJECT public: - BuildStepConfigWidget() - : QWidget() - {} virtual QString summaryText() const = 0; virtual QString additionalSummaryText() const { return QString(); } virtual QString displayName() const = 0; @@ -134,20 +128,16 @@ signals: void updateAdditionalSummary(); }; -class PROJECTEXPLORER_EXPORT SimpleBuildStepConfigWidget - : public BuildStepConfigWidget +class PROJECTEXPLORER_EXPORT SimpleBuildStepConfigWidget : public BuildStepConfigWidget { Q_OBJECT public: - SimpleBuildStepConfigWidget(BuildStep *step) - : m_step(step) + SimpleBuildStepConfigWidget(BuildStep *step) : m_step(step) { connect(m_step, &ProjectConfiguration::displayNameChanged, this, &BuildStepConfigWidget::updateSummary); } - ~SimpleBuildStepConfigWidget() {} - QString summaryText() const { return QLatin1String("<b>") + displayName() + QLatin1String("</b>"); } QString displayName() const { return m_step->displayName(); } bool showWidget() const { return false; } @@ -161,5 +151,3 @@ private: Q_DECLARE_METATYPE(ProjectExplorer::BuildStep::OutputFormat) Q_DECLARE_METATYPE(ProjectExplorer::BuildStep::OutputNewlineSetting) - -#endif // BUILDSTEP_H |