diff options
author | Eike Ziller <eike.ziller@qt.io> | 2017-04-25 16:15:04 +0200 |
---|---|---|
committer | Eike Ziller <eike.ziller@qt.io> | 2017-04-25 16:15:04 +0200 |
commit | 56233f67e1b4dbcb1fcd8b5c689765da0f7eaa2b (patch) | |
tree | dd923b4c2d0eaa834c87fa175120b373b511bad0 /src/plugins/qmldesigner/designercore/metainfo/nodemetainfo.cpp | |
parent | 73f210dad6b3509a7dfb397ae484209dc8e4493b (diff) | |
parent | e574860cf0d5b978b772d69c66f78239290d23f7 (diff) |
Merge remote-tracking branch 'origin/4.3'
Change-Id: I01d7d8aa282f2bca94f85f55c832c76672e229f7
Diffstat (limited to 'src/plugins/qmldesigner/designercore/metainfo/nodemetainfo.cpp')
-rw-r--r-- | src/plugins/qmldesigner/designercore/metainfo/nodemetainfo.cpp | 33 |
1 files changed, 17 insertions, 16 deletions
diff --git a/src/plugins/qmldesigner/designercore/metainfo/nodemetainfo.cpp b/src/plugins/qmldesigner/designercore/metainfo/nodemetainfo.cpp index 10605c3445..66e636f20a 100644 --- a/src/plugins/qmldesigner/designercore/metainfo/nodemetainfo.cpp +++ b/src/plugins/qmldesigner/designercore/metainfo/nodemetainfo.cpp @@ -575,10 +575,10 @@ private: void initialiseProperties(); TypeName m_qualfiedTypeName; - int m_majorVersion; - int m_minorVersion; - bool m_isValid; - bool m_isFileComponent; + int m_majorVersion = -1; + int m_minorVersion = -1; + bool m_isValid = false; + bool m_isFileComponent = false; PropertyNameList m_properties; PropertyNameList m_signals; QList<TypeName> m_propertyTypes; @@ -673,10 +673,11 @@ NodeMetaInfoPrivate::NodeMetaInfoPrivate() : m_isValid(false) } -NodeMetaInfoPrivate::NodeMetaInfoPrivate(Model *model, TypeName type, int maj, int min) : - m_qualfiedTypeName(type), m_majorVersion(maj), - m_minorVersion(min), m_isValid(false), m_isFileComponent(false), - m_model(model) +NodeMetaInfoPrivate::NodeMetaInfoPrivate(Model *model, TypeName type, int maj, int min) + : m_qualfiedTypeName(type) + , m_majorVersion(maj) + , m_minorVersion(min) + , m_model(model) { if (context()) { const CppComponentValue *cppObjectValue = getCppComponentValue(); @@ -1003,7 +1004,7 @@ static QByteArray getPackage(const QByteArray &name) bool NodeMetaInfoPrivate::cleverCheckType(const TypeName &otherType) const { if (otherType == qualfiedTypeName()) - return true; + return true; if (isFileComponent()) return false; @@ -1177,8 +1178,8 @@ QString NodeMetaInfoPrivate::lookupName() const QStringList NodeMetaInfoPrivate::lookupNameComponent() const { - QString tempString = fullQualifiedImportAliasType(); - return tempString.split('.'); + QString tempString = fullQualifiedImportAliasType(); + return tempString.split('.'); } @@ -1415,7 +1416,6 @@ QStringList NodeMetaInfo::propertyKeysForEnum(const PropertyName &propertyName) QVariant NodeMetaInfo::propertyCastedValue(const PropertyName &propertyName, const QVariant &value) const { - const QVariant variant = value; QVariant copyVariant = variant; if (propertyIsEnumType(propertyName) @@ -1489,10 +1489,12 @@ TypeName NodeMetaInfo::typeName() const { return m_privateData->qualfiedTypeName(); } + int NodeMetaInfo::majorVersion() const { return m_privateData->majorVersion(); } + int NodeMetaInfo::minorVersion() const { return m_privateData->minorVersion(); @@ -1537,8 +1539,7 @@ bool NodeMetaInfo::isSubclassOf(const TypeName &type, int majorVersion, int mino if (typeName().isEmpty()) return false; - if (typeName() == type - && availableInVersion(majorVersion, minorVersion)) + if (typeName() == type && availableInVersion(majorVersion, minorVersion)) return true; if (m_privateData->prototypeCachePositives().contains(Internal::stringIdentifier(type, majorVersion, minorVersion))) @@ -1549,8 +1550,8 @@ bool NodeMetaInfo::isSubclassOf(const TypeName &type, int majorVersion, int mino foreach (const NodeMetaInfo &superClass, superClasses()) { if (superClass.m_privateData->cleverCheckType(type) - && superClass.availableInVersion(majorVersion, minorVersion)) { - m_privateData->prototypeCachePositives().insert(Internal::stringIdentifier(type, majorVersion, minorVersion)); + && superClass.availableInVersion(majorVersion, minorVersion)) { + m_privateData->prototypeCachePositives().insert(Internal::stringIdentifier(type, majorVersion, minorVersion)); return true; } } |